Closed fcgravalos closed 5 years ago
Merging #33 into master will not change coverage. The diff coverage is
0%
.
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 8 8
Lines 427 427
=======================================
Hits 359 359
Misses 51 51
Partials 17 17
Impacted Files | Coverage Δ | |
---|---|---|
controllers/secretdefinition_controller.go | 75.78% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 31a0ca8...3b86fa2. Read the comment docs.
Deleting a secretDefinition will hang if a secret doesn't exist yet. This can happen if the secret is not present in Vault and you prefer to delete the secretDefinition until you have it deployed in Vault.
Updating the finalizer associated with the secretDefinition to be just
[]
can fix it, but I just find more appropiate to just don't try to delete the secret if it does not exist