search

tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Adding suggestions pr39 #42

Closed eduardogr closed 4 years ago

eduardogr commented 4 years ago

resolves #41

codecov-io commented 4 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files           8        8           
  Lines         432      432           
=======================================
  Hits          364      364           
  Misses         51       51           
  Partials       17       17
Impacted Files Coverage Δ
controllers/secretdefinition_controller.go 77.03% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0db2d9...f961b2b. Read the comment docs.

eduardogr commented 4 years ago

Finally issues short links like #39 doesn't apply in markdown, so i didn't include it here