tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Missing return provokes wrong metrics delivery #47

Closed eduardogr closed 4 years ago

eduardogr commented 4 years ago

We missed a return statement after the line 156 of the backend/vault.go file:

and this is provoking that we are sending successful login metrics when we shouldn't:

c.logger.Info("login successful, got a new vault token")

dannyk81 commented 4 years ago

yes, indeed :sweat_smile: @fcgravalos actually caught that last week when we had a sealed Vault.

We'll do a quick PR to fix this, thanks for noticing this too :+1:

eduardogr commented 4 years ago

i've just created the issue because he told me about that, i'm doing a quick fix, as soon as i upload it i create the PR