tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Secrets Manager should default to run as Non-Root #50

Closed avenging closed 4 years ago

avenging commented 4 years ago

I believe that the Dockerfile should be adjusted slightly so that secrets-manager does not run as root by default. I have created and image myself like this and it seems to work fine.

Merge request incoming.

fcgravalos commented 4 years ago

This makes total sense to me :). Good catch!

jeroenrinzema commented 4 years ago

I think this issue can safely be closed 🙌