search

tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Last sync status needs to be outside of the test for updated as not e… #58

Closed avenging closed 3 years ago

avenging commented 4 years ago

Fixes #57

codecov-io commented 4 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files           8        8           
  Lines         433      433           
=======================================
  Hits          368      368           
  Misses         48       48           
  Partials       17       17
Impacted Files Coverage Δ
controllers/secretdefinition_controller.go 77.03% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fda604...0785e92. Read the comment docs.

eduardogr commented 3 years ago

LGTM, thanks for this @avenging !