tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Support for PKI secrets engine #63

Closed rvojcik closed 3 years ago

rvojcik commented 4 years ago

Hi,

thank you all for your great project. We are using it on number of clusters in our infrastructure. Thanx again for adding support for Approle auth, it's great !

I facing now little challenge. We are using Vault as CA for number of applications which needs client certificates so we have number of Intermediate CAs in vault and generating signed certificates very easily.

I will be great if the secrets-manager have support for PKI secrets engine. I have workaround already so it's just kind of feature request which can simplify my setup and maybe helps someone.

For PKI it's not just secret but always a certificate. Secrets manager should have different behaviour for this

From configuration point of view, user shoud provide following information (in resource object)

markAcomm commented 4 years ago

May I suggest you look at cert-manager which is referenced on this project's home page? It sounds like it is designed to do what you are looking for.

This tool is great for what it was designed for and we use it quite a lot, but the suggested features are a bit far afield from its primary purpose. Yes, I understand the rationale it may be a general purpose Vault-K8s secrets bridge, but certificates have a whole new set of requirements to consider.

rvojcik commented 3 years ago

@markAcomm thx that's great. I didn't know that cert-manager support vault already.