tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

feat: Cluster role aggregation #69

Closed raelga closed 4 years ago

raelga commented 4 years ago

Status

READY

Migrations

NO

Description

Adds the cluster role aggregations yaml files required to add secretdefinitions actions to admin, view and edit native Kubernetes cluster roles.

Type of change

How Has This Been Tested?

Check admin cluster role before and after applying the admin role aggregation:

❯ kubectl describe clusterrole admin | grep secrets-manager.tuenti.io

❯ kubectl apply -f config/rbac/secretdefinitions_admin_clusterrole_aggregation.yaml   
clusterrole.rbac.authorization.k8s.io/aggregate-secretdefinitions-admin-edit created

❯ kubectl describe clusterrole admin | grep secrets-manager.tuenti.io              
  secretdefinitions.secrets-manager.tuenti.io                []                 []                                      [get list watch create update patch delete deletecollection]

Check view cluster role before and after applying the admin role aggregation:

❯ kubectl describe clusterrole view | grep secrets-manager.tuenti.io               

❯ kubectl apply -f config/rbac/secretdefinitions_view_clusterrole_aggregation.yaml
clusterrole.rbac.authorization.k8s.io/aggregate-secretdefinitions-view created

❯ kubectl describe clusterrole view | grep secrets-manager.tuenti.io              
  secretdefinitions.secrets-manager.tuenti.io               []                 []                                      [get list watch]

Checklist:

codecov-commenter commented 4 years ago

Codecov Report

Merging #69 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files           8        8           
  Lines         434      434           
=======================================
  Hits          370      370           
  Misses         47       47           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 278cd7a...92612b8. Read the comment docs.