tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets

Apache License 2.0

171 stars 26 forks source link

Update README.md #70

Closed user-name-is-taken closed 3 years ago

user-name-is-taken commented 3 years ago

Status

READY

Migrations

YES (describe migration) | NO

Description

Fixing a broken link in the readme

List of fixes # (issue)

None

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

How Has This Been Tested?

Clicking the link

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

eduardogr commented 3 years ago

Hi @user-name-is-taken, we do not accept this kind of PRs, this adds no value to the project. I will review our contributing guidelines to clarify this, by the moment, you can open an issue to point this kind of suggestions.