tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets

Apache License 2.0

171 stars 26 forks source link

Upgrade apiVersion of CRD and propagating annotations and labels from secret definition to secret #77

Closed eduardogr closed 3 years ago

eduardogr commented 3 years ago

Status

READY

Migrations

Yes, Migrating from apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1

Description

Upgrading apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1
Populating annotations and labels from secret definition to the created secret

List of fixes # (issue)

fix #71
fix #62

Type of change

[X] New feature (non-breaking change which adds functionality)
[X] This change requires a documentation update

How Has This Been Tested?

with secrets-manager tests

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

eduardogr commented 3 years ago

going to solve it in a different PR, merging changes with PR https://github.com/tuenti/secrets-manager/pull/64 and resolving its conflicts