avenging commented 2 years ago

Status

READY

Migrations

Changes to the config map used for leader elections (now created automatically) means that a config map with specific name no longer needs to exist of there is more than one Secrets Manager pod running in a replica set. Old Config Maps can be removed

Description

Fix the CRD for latest version of k8s Update to go 1.16 update kubebuilder 3.1.0 Basically bring things a bit up-to-date

List of fixes # (issue)

Fixes the fact the CRD is broken on newer k8s versions (even with the change to v1 already done)
Fixes the ancient version of Go which mean the CA certificated in the Docker container were so old some libraries could no longer be pulled on build due to SSL certificate issues
Fixes ancient version of Kubebuilder and controller-gen so newer CRD can be genereated.
Some things have been removed (they seemed irrelevant anyway)
Believed to also fix #83

Type of change

Mass update to the libraries used.

This may potentially break things, but I haven't found anything broken.... Except the fact the CRD at least will no longer deploy on k8s < v1.16

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

The test suite has been updated and run and all tests continue to pass. Deployed into a k8s cluster in different configurations

Global
Single namespacaed

Created and updated secretdefinitions to make sure everything still works.

Please also list any relevant details for your test configuration

Kubernetes 1.21
EKS cluster

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

codecov-commenter commented 2 years ago

Codecov Report

Merging #81 (ceea1f0) into master (1162dc8) will increase coverage by 2.03%. The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   82.60%   84.64%   +2.03%     
==========================================
  Files           8        9       +1     
  Lines         414      482      +68     
==========================================
+ Hits          342      408      +66     
- Misses         54       56       +2     
  Partials       18       18

Impacted Files	Coverage Δ
controllers/secretdefinition_controller.go	`80.64% <90.90%> (+2.44%)`	:arrow_up:
errors/errors.go	`100.00% <0.00%> (ø)`
backend/backend.go	`100.00% <0.00%> (ø)`
backend/decoder.go	`100.00% <0.00%> (ø)`
controllers/metrics.go	`100.00% <0.00%> (ø)`
backend/vault_metrics.go	`100.00% <0.00%> (ø)`
api/v1alpha1/secretdefinition_types.go	`100.00% <0.00%> (ø)`
backend/vault.go	`75.14% <0.00%> (+1.42%)`	:arrow_up:
backend/vault_engine.go	`87.50% <0.00%> (+2.88%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1162dc8...ceea1f0. Read the comment docs.

fcgravalos commented 2 years ago

Nice! I will take a look

avenging commented 2 years ago

Thanks for the review will try and get a bit of time early next week to update/commit fixes.

fcrespofastly commented 2 years ago

Hey @avenging! Do you need any help with this?

fcrespofastly commented 2 years ago

Hey @avenging happy new year!

How's it going with the PR changes I suggested?

tuenti / secrets-manager

Update to kubebuilder 3.1.0 #81