tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
80 stars 26 forks source link

Dominos error causing keybinds to not be usable #690

Closed vezevez closed 8 months ago

vezevez commented 1 year ago

Addon Version: 10.0.12 World of Warcraft Version: Retail

Getting an error whenever I load into a new area where some of my keybinds stop working, causing me to reload, with a blizzard error popping up asking if I want to disable Dominos. Below I have attached the bugsack errors that come up when this happens.


1x [ADDON_ACTION_BLOCKED] AddOn 'Dominos' tried to call the protected function 'ActionButton5:SetAttribute()'. [string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480> string "=[C]": in function SetAttribute' [string "@FrameXML/ActionButton.lua"]:350: in functionUpdatePressAndHoldAction' [string "@FrameXML/ActionButton.lua"]:412: in function <FrameXML/ActionButton.lua:373> string "=[C]": in function Update' [string "@FrameXML/ActionButton.lua"]:362: in functionUpdateAction' [string "@FrameXML/ActionButton.lua"]:354: in function <FrameXML/ActionButton.lua:353> string "=[C]": in function SetAttribute' [string "@FrameXML/RestrictedFrames.lua"]:506: in functionSetAttribute' [string " if name ~= "action" then return end

        local target = control:GetFrameRef("target")
        if target and target:GetAttribute(name) ~= value then
            target:SetAttribute(name, value)
        end
    "]:5: in function <[string "            if name ~= "action" then return..."]:1>

... [string "@FrameXML/RestrictedFrames.lua"]:739: in function `RunAttribute' [string " self:RunAttribute('updateOverridePage') "]:1: in function <[string " self:RunAttribute('updateOverridePage')..."]:1>

[string "@FrameXML/RestrictedExecution.lua"]:484: in function <FrameXML/RestrictedExecution.lua:447>

[string "@FrameXML/SecureHandlers.lua"]:115: in function <FrameXML/SecureHandlers.lua:110> string "=[C]": in function `SetAttribute' [string "@FrameXML/SecureStateDriver.lua"]:114: in function <FrameXML/SecureStateDriver.lua:95> [string "@FrameXML/SecureStateDriver.lua"]:127: in function <FrameXML/SecureStateDriver.lua:119>


1x [ADDON_ACTION_BLOCKED] AddOn 'Dominos' tried to call the protected function 'OverrideActionBarButton2:SetAttribute()'. [string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480> string "=[C]": in function SetAttribute' [string "@FrameXML/ActionButton.lua"]:350: in functionUpdatePressAndHoldAction' [string "@FrameXML/ActionButton.lua"]:412: in function <FrameXML/ActionButton.lua:373> string "=[C]": in function Update' [string "@FrameXML/ActionButton.lua"]:910: in functionOnEvent' [string "@FrameXML/ActionButton.lua"]:264: in function <FrameXML/ActionButton.lua:256>

Tuller commented 1 year ago

Have you encountered the issue with just Dominos enabled? This one is related to something tainting the secure execution path, which could be Dominos, but can easily be other things too.

vezevez commented 1 year ago

It seems to happen whenever I change zones via portal or hearthstone, entering a dungeon, etc. Basically right after I zone somewhere I need to /reload to fix it. So far it seems like just a Dominos issue (since the last update) but I will update if I can pinpoint another addon causing it.

BlueLemon1 commented 1 year ago

I have the same problem but for me it was showing that "Masque" was the Issue. Disabled "Masque" then it was "Elvui_Libs". So i guess it must be library related. For me it started working when i was disabling "Elvui_WindTools"

hollo6 commented 1 year ago

For me a different addon gets blamed every time, AutoTurnIn, WorldQuestsList, Angrier World Quests, basically anything. If I disable them one by one, the next time it happens it's something else. I was told by the author of one of these that something is causing taint, and the issue just pops up later. I believe the origin of this is Dominos.

jonjbm commented 1 year ago

As I said in another post, this is definitely caused by Dominos. I disabled every addon except Dominos and still got these types of errors.

Squatty1 commented 1 year ago

I keep having this exact issue as well, only happens when I enable dominos. Any other action button addon works.

Squatty1 commented 1 year ago

I have not had the bug since I disabled LibKeyBound

hollo6 commented 1 year ago

How do you do that?

Squatty1 commented 1 year ago

Just disabled it in the addon list. I have now played maybe 10hours without an error. I cannot promise it's a fix though.

hollo6 commented 1 year ago

I don't have that installed separately, only included in Dominos libs.

Tuller commented 8 months ago

Closing #701 related issues