tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
80 stars 26 forks source link

Extreme stutter with Action Bar paging #707

Closed RafVanUffel closed 1 year ago

RafVanUffel commented 1 year ago

Ever since prepatch at random points during heavy play like mythic dungeons or just after a long while of normal play I'll get the error

5x [ADDON_ACTION_BLOCKED] AddOn 'Dominos' tried to call the protected function 'DominosActionButton76:SetAttribute()'. [string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480> [string "=[C]"]: in function SetAttribute' [string "@FrameXML/ActionButton.lua"]:350: in functionUpdatePressAndHoldAction' [string "@FrameXML/ActionButton.lua"]:412: in function <FrameXML/ActionButton.lua:373> [string "=[C]"]: in function Update' [string "@FrameXML/ActionButton.lua"]:910: in functionOnEvent' [string "@FrameXML/ActionButton.lua"]:264: in function <FrameXML/ActionButton.lua:256>

This usually occurs in combat, shortly after receiving this error whenever using CTRL, SHIFT or ALT to page actionbars, my game freezes for a second due to the flood of lua errors which has caused some deaths mosdef, checking BugGrabber shows me absolutely massive amounts of

44527x FrameXML/EditModeUtil.lua:27: attempt to perform arithmetic on local 'offsetX' (a nil value) [string "@FrameXML/EditModeUtil.lua"]:27: in function GetRightActionBarWidth' [string "@FrameXML/EditModeUtil.lua"]:53: in functionGetRightContainerAnchor' [string "@FrameXML/UIParent.lua"]:3082: in function UIParentManageFramePositions' [string "@FrameXML/UIParent.lua"]:2561: in function <FrameXML/UIParent.lua:2548> [string "=[C]"]: in functionSetAttribute' [string "@FrameXML/UIParent.lua"]:3104: in function <FrameXML/UIParent.lua:3102> string "=[C]": in function UIParent_ManageFramePositions' [string "@FrameXML/EditModeManager.lua"]:646: in function <FrameXML/EditModeManager.lua:610> [string "=[C]"]: in functionUpdateBottomActionBarPositions' [string "@FrameXML/EditModeManager.lua"]:555: in function UpdateActionBarLayout' [string "@FrameXML/EditModeSystemTemplates.lua"]:648: in functionUpdateGridLayout' [string "@FrameXML/ActionBar.lua"]:350: in function `UpdateVisibility' [string "@FrameXML/ActionBar.lua"]:282: in function <FrameXML/ActionBar.lua:278>

Locals: self =

{ GetSettingMapFromSettings = defined @FrameXML/EditModeUtil.lua:58 IsRightAnchoredActionBar = defined @FrameXML/EditModeUtil.lua:3 GetRightContainerAnchor = defined @FrameXML/EditModeUtil.lua:52 IsBottomAnchoredActionBar = defined @FrameXML/EditModeUtil.lua:8 GetRightActionBarWidth = defined @FrameXML/EditModeUtil.lua:18 GetBottomActionBarHeight = defined @FrameXML/EditModeUtil.lua:33 } offset = 0 point = nil relativeTo = nil relativePoint = nil offsetX = nil offsetY = nil (temporary) = 44.999962 (temporary) = 44.999962 (*temporary) = MultiBarLeft { 0 = buttonPadding = 2 UpdateSystemSettingAlwaysShowButtons = defined @FrameXML/EditModeSystemTemplates.lua:765 UpdateMagnetismRegistration = defined @FrameXML/EditModeSystemTemplates.lua:499 GetSnapOffsets = defined @FrameXML/EditModeSystemTemplates.lua:404 UpdateFrameStrata = defined @FrameXML/ActionBar.lua:194 UpdateButtonArt = defined @FrameXML/EditModeSystemTemplates.lua:662 IsFrameAnchoredToMe = defined @FrameXML/EditModeSystemTemplates.lua:462 buttonTemplate = "MultiBar4ButtonTemplate" ShowBase = defined =[C]:-1 IsShown = defined @FrameXML/ActionBar.lua:286 GetSelectionOffset = defined @FrameXML/EditModeSystemTemplates.lua:356 ResetToDefaultPosition = defined @FrameXML/EditModeSystemTemplates.lua:148 RefreshButtonArt = defined @FrameXML/EditModeSystemTemplates.lua:655 GetScaledSelectionSides = defined @FrameXML/EditModeSystemTemplates.lua:348 SelectSystem = defined @FrameXML/EditModeSystemTemplates.lua:527 buttonArtDirty = false GetFrameMagneticEligibility = defined @FrameXML/EditModeSystemTemplates.lua:482 AddLayoutChildren = defined @SharedXML/LayoutFrame.lua:48 IsBelowFrame = defined @FrameXML/EditModeSystemTemplates.lua:315 UpdateSystemSettingIconSize = defined @FrameXML/EditModeSystemTemplates.lua:707 SetScaleBase = defined =[C]:-1 HasActiveChanges = defined @FrameXML/EditModeSystemTemplates.lua:237 GetScaledCenter = defined @FrameXML/EditModeSystemTemplates.lua:341 DoesSettingDisplayValueEqual = defined @FrameXML/EditModeSystemTemplates.lua:261 Layout = defined @SharedXML/LayoutFrame.lua:333 settingDisplayInfoMap =
{ } addSystemIndexToName = true IsLayoutFrame = defined @SharedXML/LayoutFrame.lua:36 DoesSettingValueEqual = defined @FrameXML/EditModeSystemTemplates.lua:256 MarkDirty = defined @SharedXML/LayoutFrame.lua:90 ShouldResetSettingsDialogAnchors = defined @FrameXML/EditModeSystemTemplates.lua:91 dirtySettings =
{ } UpdateGridLayout = defined @FrameXML/EditModeSystemTemplates.lua:641 IsToTheLeftOfFrame = defined @FrameXML/EditModeSystemTemplates.lua:297 GetSettingsDialogAnchor = defined @FrameXML/EditModeSystemTemplates.lua:281 hasActiveChanges = false OnSystemLoad = defined @FrameXML/EditModeSystemTemplates.lua:3 ClearFrameSnap = defined @FrameXML/EditModeSystemTemplates.lua:441 GetCombinedCenterOffset = defined @FrameXML/EditModeSystemTemplates.lua:391 SetupSettingsDialogAnchor = defined @FrameXML/EditModeSystemTemplates.lua:225 IsShownOverride = defined @FrameXML/ActionBar.lua:286 dirty = false SetPointBase = defined =[C]:-1 UpdateSystem = defined @FrameXML/EditModeSystemTemplates.lua:579 CacheGridSettings = d

Tuller commented 1 year ago

Are you getting this one with just Dominos + Domios_Config enabled?

sod commented 1 year ago

it happens with both, config enabled and not loaded. It paginates a few times until you see the stack overflow error, than paging stops showing. But for me at least shortcuts still work

sod commented 1 year ago

It was perfectly reproducable yesterday, but I was busy playing. Today I wanted to debug, and now the error doesn't happen. Super weird -.-