search

tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
79 stars 27 forks source link

Patch day errors #845

Closed thisisu closed 3 months ago

thisisu commented 3 months ago

When reporting an issue, please try to reproduce the issue with just Dominos and Dominos_Config running. Dominos reuses a good chunk of the stock UI, and other popular addons, like Move Anything, like to take control of those parts, too.

Addon Version Dominos: 10.2.22-retail

World of Warcraft Version Retail

243x FrameXML/MainMenuBarMicroButtons.lua:1623: attempt to compare two nil values [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1623: in function GetEdgeButton' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1651: in functionUpdateHelpTicketButtonAnchor' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1710: in function Layout' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1759: in functionLayout' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:413: in function <FrameXML/MainMenuBarMicroButtons.lua:412>

string "=[C]": in function Hide' [string "@Dominos/bars/menuBar.lua"]:168: in functionLayout' [string "@Dominos/core/buttonBar.lua"]:89: in function ReloadButtons' [string "@Dominos/bars/menuBar.lua"]:133: in functionReloadButtons' [string "@Dominos/core/buttonBar.lua"]:16: in function <Dominos/core/buttonBar.lua:15>

... [string "@FrameXML/UIParent.lua"]:777: in function MajorFactions_LoadUI' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:179: in functionSetUpMajorFactionList' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:172: in function RefreshMajorFactionList' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:167: in functionRefreshOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:158: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:154>

string "=[C]": in function CreateFrame' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:122: in functionCreateOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:63: in function `RefreshExpansionOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:35: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:33>

Locals: self = MicroMenu { IsLayoutFrame = defined @SharedXML/LayoutFrame.lua:36 GetEdgeButton = defined @FrameXML/MainMenuBarMicroButtons.lua:1600 ShouldUpdateLayout = defined @SharedXML/LayoutFrame.lua:483 MarkDirty = defined @SharedXML/LayoutFrame.lua:99 SetHeightPadding = defined @SharedXML/LayoutFrame.lua:160 layoutFramesGoingRight = true OnCleaned = defined @SharedXML/LayoutFrame.lua:131 isHorizontal = true OnUpdate = defined @SharedXML/LayoutFrame.lua:93 GetAdditionalRegions = defined @SharedXML/LayoutFrame.lua:85 GetFixedSize = defined @SharedXML/LayoutFrame.lua:156 OnShow = defined @SharedXML/LayoutFrame.lua:32 GetHeightPadding = defined @SharedXML/LayoutFrame.lua:164 UpdateFramerateFrameAnchor = defined @FrameXML/MainMenuBarMicroButtons.lua:1666 GetFixedWidth = defined @SharedXML/LayoutFrame.lua:148 dirty = false stride = 12 GetWidthPadding = defined @SharedXML/LayoutFrame.lua:168 childYPadding = -5 SetScaleAdjustment = defined @FrameXML/MainMenuBarMicroButtons.lua:1713 layoutFramesGoingUp = false UpdateQueueStatusAnchors = defined @FrameXML/MainMenuBarMicroButtons.lua:1656 SetFixedWidth = defined @SharedXML/LayoutFrame.lua:135 InitializeButtons = defined @FrameXML/MainMenuBarMicroButtons.lua:1565 GetFixedHeight = defined @SharedXML/LayoutFrame.lua:152 MarkClean = defined @SharedXML/LayoutFrame.lua:117 CacheLayoutSettings = defined @SharedXML/LayoutFrame.lua:471 SetFixedSize = defined @SharedXML/LayoutFrame.lua:143 GetLayoutChildren = defined @SharedXML/LayoutFrame.lua:73 numButtons = 12 IsDirty = defined @SharedXML/LayoutFrame.lua:127 OnLoad = defined @FrameXML/MainMenuBarMicroButtons.lua:1560 oldGridSettings =

{ } Layout = defined @FrameXML/MainMenuBarMicroButtons.lua:1703 SetFixedHeight = defined @SharedXML/LayoutFrame.lua:139 AnchorToMenuContainer = defined @FrameXML/MainMenuBarMicroButtons.lua:1674 SetQueueStatusScale = defined @FrameXML/MainMenuBarMicroButtons.lua:1695 0 = UpdateHelpTicketButtonAnchor = defined @FrameXML/MainMenuBarMicroButtons.lua:1634 AddButton = defined @FrameXML/MainMenuBarMicroButtons.lua:1591 MarkIgnoreInLayout = defined @SharedXML/LayoutFrame.lua:44 AddLayoutChildren = defined @SharedXML/LayoutFrame.lua:55 childXPadding = -5 IgnoreLayoutIndex = defined @SharedXML/LayoutFrame.lua:515 } rightMost = false topMost = true firstButton = HelpMicroButton { 0 = OnEnter = defined @FrameXML/MainMenuBarMicroButtons.lua:353 FlashBorder = Texture { } QuickKeybindButtonOnShow = defined @FrameXML/QuickKeybind.lua:4 QuickKeybindButtonOnEnter = defined @FrameXML/QuickKeybind.lua:22 DoModeChange = defined @FrameXML/QuickKeybind.lua:95 QuickKeybindButtonOnUpdate = defined @FrameXML/QuickKeybind.lua:75 tooltipText = "Customer Support" QuickKeybindButtonOnLeave = defined @FrameXML/QuickKeybind.lua:33 OnMouseDown = defined @FrameXML/MainMenuBarMicroButtons.lua:416 Background = Texture { } PushedBackground = Texture { } QuickKeybindButtonSetTooltip = defined @FrameXML/QuickKeybind.lua:52 layoutIndex = 10 OnShow = defined @FrameXML/MainMenuBarMicroButtons.lua:408 OnLoad = defined @FrameXML/MainMenuBarMicroButtons.l

Geekly commented 3 months ago

I only have Dominos and Dominos_config and Buggrabber/Bugsack running. Wow doesn't like what Dominos is doing to the Menu Bar Buttons element. Addon Version Dominos: 10.2.22-retail World of Warcraft Version Retail

I get an error similar to this whenever I activate one of the menu items, either by clicking the button or by using a hotkey.

138x FrameXML/MainMenuBarMicroButtons.lua:1623: attempt to compare number with nil [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1623: in function GetEdgeButton' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1651: in functionUpdateHelpTicketButtonAnchor' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1710: in function Layout' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:1759: in functionLayout' [string "@FrameXML/MainMenuBarMicroButtons.lua"]:413: in function <FrameXML/MainMenuBarMicroButtons.lua:412>

string "=[C]": in function SetParent' [string "@Dominos/core/buttonBar.lua"]:53: in functionAttachButton' [string "@Dominos/core/buttonBar.lua"]:86: in function ReloadButtons' [string "@Dominos/bars/menuBar.lua"]:133: in functionReloadButtons' [string "@Dominos/core/buttonBar.lua"]:16: in function <Dominos/core/buttonBar.lua:15> ... [string "@FrameXML/UIParent.lua"]:572: in function UIParentLoadAddOn' [string "@FrameXML/UIParent.lua"]:777: in functionMajorFactions_LoadUI' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:179: in function SetUpMajorFactionList' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:172: in functionRefreshMajorFactionList' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:167: in function RefreshOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:158: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:154> [string "=[C]"]: in functionCreateFrame' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:122: in function CreateOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:63: in functionRefreshExpansionOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:35: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:33>

Locals: self = MicroMenu { IsLayoutFrame = defined @SharedXML/LayoutFrame.lua:36 GetEdgeButton = defined @FrameXML/MainMenuBarMicroButtons.lua:1600 ShouldUpdateLayout = defined @SharedXML/LayoutFrame.lua:483 MarkDirty = defined @SharedXML/LayoutFrame.lua:99 SetHeightPadding = defined @SharedXML/LayoutFrame.lua:160 layoutFramesGoingRight = true OnCleaned = defined @SharedXML/LayoutFrame.lua:131 isHorizontal = true OnUpdate = defined @SharedXML/LayoutFrame.lua:93 GetAdditionalRegions = defined @SharedXML/LayoutFrame.lua:85 GetFixedSize = defined @SharedXML/LayoutFrame.lua:156 OnShow = defined @SharedXML/LayoutFrame.lua:32 GetHeightPadding = defined @SharedXML/LayoutFrame.lua:164 UpdateFramerateFrameAnchor = defined @FrameXML/MainMenuBarMicroButtons.lua:1666 GetFixedWidth = defined @SharedXML/LayoutFrame.lua:148 dirty = false stride = 12 GetWidthPadding = defined @SharedXML/LayoutFrame.lua:168 childYPadding = -5 SetScaleAdjustment = defined @FrameXML/MainMenuBarMicroButtons.lua:1713 layoutFramesGoingUp = false UpdateQueueStatusAnchors = defined @FrameXML/MainMenuBarMicroButtons.lua:1656 SetFixedWidth = defined @SharedXML/LayoutFrame.lua:135 InitializeButtons = defined @FrameXML/MainMenuBarMicroButtons.lua:1565 GetFixedHeight = defined @SharedXML/LayoutFrame.lua:152 MarkClean = defined @SharedXML/LayoutFrame.lua:117 CacheLayoutSettings = defined @SharedXML/LayoutFrame.lua:471 SetFixedSize = defined @SharedXML/LayoutFrame.lua:143 GetLayoutChildren = defined @SharedXML/LayoutFrame.lua:73 numButtons = 12 IsDirty = defined @SharedXML/LayoutFrame.lua:127 OnLoad = defined @FrameXML/MainMenuBarMicroButtons.lua:1560 oldGridSettings =

{ } Layout = defined @FrameXML/MainMenuBarMicroButtons.lua:1703 SetFixedHeight = defined @SharedXML/LayoutFrame.lua:139 AnchorToMenuContainer = defined @FrameXML/MainMenuBarMicroButtons.lua:1674 SetQueueStatusScale = defined @FrameXML/MainMenuBarMicroButtons.lua:1695 0 = UpdateHelpTicketButtonAnchor = defined @FrameXML/MainMenuBarMicroButtons.lua:1634 AddButton = defined @FrameXML/MainMenuBarMicroButtons.lua:1591 MarkIgnoreInLayout = defined @SharedXML/LayoutFrame.lua:44 AddLayoutChildren = defined @SharedXML/LayoutFrame.lua:55 childXPadding = -5 IgnoreLayoutIndex = defined @SharedXML/LayoutFrame.lua:515 } rightMost = false topMost = true firstButton = QuestLogMicroButton { 0 = OnLeave = defined @FrameXML/MainMenuBarMicroButtons.lua:379 FlashBorder = Texture { } DoModeChange = defined @FrameXML/QuickKeybind.lua:95 QuickKeybindButtonOnLeave = defined @FrameXML/QuickKeybind.lua:33 OnClick = defined @FrameXML/MainMenuBarMicroButtons.lua:780 QuickKeybindButtonSetTooltip = defined @FrameXML/QuickKeybind.lua:52 OnShow = defined @FrameXML/MainMenuBarMicroButtons.lua:408 QuickKeybindHighlightTexture = Texture { } SetPushed = defined @FrameXML/MainMenuBarMicroButtons.lua:387 UpdateMouseWheelHandler = defined @FrameXML/QuickKeybind.lua:86 QuickKeybindButtonOnMouseWheel = defined @FrameXML/QuickKeybind.lua:46 UpdateTooltipText = defined @FrameXML/MainMenuBarMicroButtons.lua:775 QuickKeybindButtonOnShow = defined @I

Geekly commented 3 months ago

If I disable the Domino's menu button bar (simply hiding it), the errors go away (but then I don't have a menu button bar).

Tuller commented 3 months ago

The latest version lets the stock UI control the menu bar for now (and the bag and queue status, too) as a temporary workaround. I think I may need to just write my own implementation of the bar as a longer term fix.

hollo6 commented 3 months ago

The new version always forces the bag and menu bars to appear and now there's no way to hide them. I have tried commenting them out in Dominos.toc as well to no avail. I'm able to move/resize the LFG status icon with MoveAny after this update, but if Dominos is enabled, it somehow takes precedence and I'm unable to hide the menu and bag bars - there is no such option in Edit Mode and MA cannot get a handle on them. Is there something I can do to prevent this?

Tuller commented 3 months ago

A more permanent fix should now be in place.

thisisu commented 3 months ago

Ty Tuller

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.