period pattern needs work

turbomam / mixs-subset-examples-first

A subset of the MIxS specification that's self-documenting and DataHarmonizer compatible. Comes with valid and invalid data examples. Subset = all checklists and all environmental packages, but partial combinations.

https://turbomam.github.io/mixs-subset-examples-first/

MIT License

0 stars 0 forks source link

period pattern needs work #103

Open turbomam opened 1 year ago

turbomam commented 1 year ago

doesn't accept many values besides P1D

  period: |-
    P(?=\d+[YMWD])(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(?=\d+[HMS])(\d+H)?(\d+M)?(\d+S)?)?

turbomam commented 1 year ago

ChatGPT says all of these should match:

P1Y
P1Y1M
P1Y2M3W
P2D
P2W5D
P2Y3M1W
P3W
P3W4D
P4M1W5D
P4W2D
P5M
P6M2W
P6M4D
~~PT15M20S~~
~~PT1M30S~~
~~PT2H~~
~~PT30M~~
~~PT3H45S~~
~~PT45S~~
~~PT4H30M~~

turbomam commented 1 year ago

most frequent example from MIxS: P1H30M

failures from above

PT15M20S
PT1M30S
PT2H
PT30M
PT3H45S
PT45S
PT4H30M

turbomam commented 1 year ago

P(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)? accepts all of the above except P1H30M. The pattern does accept PT4H30M.