search

tusharsadhwani / packaged

The easiest way to ship python applications.
https://packaged.live
GNU General Public License v2.0
193 stars 8 forks source link

Using '.' as output_path misses creating executable #18

Closed cemrehancavdar closed 6 months ago

cemrehancavdar commented 6 months ago

Hey,

I was giving a shot to packaged. I gave output_path input "." because i mostly trust defaults when i try a new tool. I understand it is stupid thing to give it a dot as input but there may be a default name and put it to cwd or it should warn.

script: packaged . 'pip install .' 'python app.py' .

tusharsadhwani commented 6 months ago

You're right, . as a path should not work.

In fact, any existing file or non-empty directory should not work.

Would erroring out with a proper message be a fine fix in this case?

cemrehancavdar commented 6 months ago

Yeah a meaningful message could cover it, thanks

tusharsadhwani commented 6 months ago

This has been fixed in v0.5.3, can you confirm?

cemrehancavdar commented 6 months ago

I confirm :100: , thanks!