search

tuxedocomputers / tuxedo-control-center

A tool to help you control performance, energy, fan and comfort settings on TUXEDO laptops.
GNU General Public License v3.0
523 stars 69 forks source link

Building against EOL Electron #148

Open blitz opened 3 years ago

blitz commented 3 years ago

As far as I can tell, TCC currently builds against electon 9.4, which is EOL. Currently supported versions can be found here.

Building against EOL electron versions is a problem for packaging, because distros tend to keep only supported Electrons around. On NixOS e.g. this results in this ugly error:

error: Package ‘electron-9.4.4’ in /nix/store/hmr8da14rdm2kkm1066208k9p2spdxji-nixpkgs-src/pkgs/development/tools/electron/generic.nix:25 is marked as insecure, refusing to evaluate.

Known issues:
 - Electron version 9.4.4 is EOL

You can install it anyway by allowing this package, using the
following methods:
...
tuxedoxt commented 3 years ago

Hello, thanks for the notice, this is on the way. At least electron should get a bump soon.

blitz commented 3 years ago

@tuxedoxt Great news!

blitz commented 3 years ago

I've seen that Electron was bumped to 11.5, which is unfortunately also EOL since end of August: https://www.electronjs.org/releases/stable?version=11

NANASHI0X74 commented 2 years ago

perhaps ypu could merge #187 ? Although according to the electron support policy at https://www.electronjs.org/docs/latest/tutorial/support#supported-versions electron 13 should also be EOL even though the latest 13.x.y's release notes don't say so. Would it be possible to bump to 17.3.1+ or 18.0.1+? This fixes some issues with wayland and they're the latest two stable releases

tuxedoxt commented 2 years ago

Hello again,

yeah sorry this has taken some time. Framework upgrades is an ongoing project. For now as of v1.1.4 electron is bumped to v13.

papanito commented 1 year ago

any updates to this?

groenator commented 9 months ago

Do we have any updates?

tuxedoder commented 9 months ago

Internally we are currently at electron 19.1.9. It isn't ready yet and needs some refactoring and testing which might take a while. A lot of changes happened because of context isolation. Electron 20+ seems a bit challenging. The goal would be electron 22, because that fixes the tray icon for plasma 6, but we might make a release for electron 19.

groenator commented 9 months ago

Awesome! Thank you for your quick response. Does that mean I should be careful using TCC in plasma 6 for now?

tuxedoder commented 9 months ago

The only issue I saw so far is a missing tray icon in plasma 6 and a lot of research and testing shows that it is fixed in electron 22. If someone finds more issues, please report them in a new issue.

groenator commented 9 months ago

Thank you!

tuxedoder commented 3 months ago

As a small update, electron 31.4.0 now seems to work in my test branch (with sandbox set to false at least), but there are still other errors I need to resolve before a release will happen and will probably take a while.