search

tuxedocomputers / tuxedo-control-center

A tool to help you control performance, energy, fan and comfort settings on TUXEDO laptops.
GNU General Public License v3.0
486 stars 63 forks source link

tcc shows fan speed is 0, even though it is noisy #392

Open harridu opened 3 weeks ago

harridu commented 3 weeks ago

After wakeup from hibernate the tuxedo control center claims the fan is at 0%, even though the fan is noisy. Before hibernate tcc showed a fan speed of 20% due to regular load.

Changing the profile or connecting the power brick doesn't help. I could reproduce this on 2 Infinitybooks (by now).

Platform is Debian 12, kernel 6.1.90, tcc is 2.1.8, tuxedo-drivers is version 4.5.0. Hardware is a shiny new Tuxedo Infinitybook Pro16.

The TUXEDO default profile has been chosen.

harridu commented 3 weeks ago

I have the impression that loading the profiles is broken after wakeup from hibernate.

nickma82 commented 2 weeks ago

Same here. Fan Speed in tuxedo-control-center is shown as 0% while fan is spinning audibly.

@harridu Ad "broken after wakeup": I can confirm, that after a fresh restart the fan works as expected.

Hardware/Software

tuxedoder commented 2 weeks ago

Currently for the fan api which the IB Pro uses, tcc shows what it thinks it configured and not the actual sensor value and shows 0 if fans are disabled globally.

https://github.com/tuxedocomputers/tuxedo-control-center/blob/bb6d0426e2185dd8d89cf68a1918c02151d66fc7/src/service-app/classes/FanControlWorker.ts#L383-L388

https://github.com/tuxedocomputers/tuxedo-control-center/blob/bb6d0426e2185dd8d89cf68a1918c02151d66fc7/src/service-app/classes/FanControlWorker.ts#L432-L438

I didn't write the initial fan control and I am not sure why it is like this, but I wanted to change it later. Otherwise fan control seems to work on my IB Pro 16 Gen 7. Fans might spin on wakeup since fans can't be instantly controlled and are in auto mode for a bit, but afterwards the fans seem to apply correctly after they get controlled by tccd or rather tuxedo-drivers. Keep in mind that fans also need some time to reach a value and how much depends on the device.

I was trying to rewrite the fan control inside tccd since a while and it seems to work fine there since I show sensor values. Based on the information I have, I think it is most likely just a display discrepancy in the dashboard and should be fixed with my rewrite. No ETA yet on when the new fan control will be public.

nickma82 commented 2 weeks ago

@tuxedoder Ad "tcc shows what it thinks it configured": That's possible an printing the desired state would in-general be okay, IF applied to the hardware in a reliable way...