search

tvo / rapid

Commandline client for Spring rapid downloading system
Other
7 stars 6 forks source link

win32 build of rapid doesn't work with unitsync of spring-master #23

Closed abma closed 13 years ago

abma commented 13 years ago

rapid pin ba:latest [...] [unitsync] initialized, 0.82+.4.0 (0.82.3-1597-ge28e19d Headless Unitsync) [unitsync] joining Traceback (most recent call last): File "C:\Python26\lib\site-packages\cx_Freeze\initscripts\Console.py", line 27 , in File "bin/rapid", line 7, in File "Z:\python\rapid\rapid\ui\text\main.py", line 117, in main File "Z:\python\rapid\rapid\unitsync\api.py", line 83, in get_writable_data_di rectory File "Z:\python\rapid\rapid\unitsync\unitsync.py", line 183, in Init ValueError: Procedure probably called with not enough arguments (4 bytes missing )

abma commented 13 years ago

this was: http://springrts.com/dl/rapid-spring-0.5.2-rc1-dllfix-win32.7z

tvo commented 13 years ago

That appears to be because this unitsync-API-breaking-change is still in master.

Was it already decided we want to keep that or is it going to be reverted? (For now I assume the last as I vaguely recall thats what we did in the release branch.)

abma commented 13 years ago

i don't know... i added it to the topics for the next meeting.

afaik rene milk is springlobby dev and this commit comes from him... so i think its better to keep it, this logging messages anoy since years :)

renefritze commented 13 years ago

That is my commit, yes, and I tought this was reverted entirely because of the fail wrt default values I wasn't aware of.

abma commented 13 years ago

hm, so maybe just add a InitLib function + mark Init as deprecated (+ remove somewhen in future?) or add a config setting to disable logging?

renefritze commented 13 years ago

Fine by me, but tbh I've since forgotten what use the unitsync silencing had.

abma commented 13 years ago

i reverted the commit, now it works again :)

(imo silencing is to not confuse users :)

abma commented 13 years ago

https://github.com/spring/spring/commit/c69ad84a55e41677400eeb0dd4cd785c42de0245