search

tweecode / twine

UI for creating hypertext stories
http://twinery.org
657 stars 97 forks source link

Fix OS X build issues #93

Closed wolfteeth closed 10 years ago

wolfteeth commented 10 years ago

These changes remedy issues I found building and running the Twine app with OS X Mavericks. Now I'm able to generate a working Twine.app that requires no other folders (in line with normal OS X application structure), and I can run the virgin app.py script if desired.

Verified the changes didn't break anything on Windows 7 -- ran app.py on its own, and ran the twine.exe file resulting from buildexe.py. Haven't tried with other versions of OS X or Windows.

webbedspace commented 10 years ago

It's actually been policy since the start that the "targets" be outside the app bundle so that users can install other story formats, such as SugarCube or Tin Cans.

But, you know what? You're right. What I'll do is make it so that OS X reads from both a targets directory inside the bundle and one outside.

wolfteeth commented 10 years ago

That occurred to me after I submitted the pull request. I like your solution.

I think the path issues with the "icons" folder are legit (see 64c4b9f above). Failure to load icon files due to incorrect path was causing a crash when I started up app.py on its own, without building it into an app first.

wolfteeth commented 10 years ago

Disregard the second half of the above comment. I see you already got the changes into your fork. Thanks! :)