twilio / twilio-conversations-demo-ios-swift

Twilio Conversations for iOS Demo application in Swift
MIT License
17 stars 18 forks source link

App crashes on loading certain conversations #17

Closed bvija03 closed 7 months ago

bvija03 commented 11 months ago
Screen Shot 2023-10-09 at 3 53 54 PM Screen Shot 2023-10-09 at 4 26 08 PM

Using the app loading certain conversations or replying to them caused the app to crash.

berkus commented 11 months ago

I believe this is known, participants without sid (or "system" user) will cause this.

Thanks for sharing the access token url - this means any baddie on the internet can now send and receive files at your expense.

bvija03 commented 11 months ago

I removed it. It was a test dummy URL. It will be disabled soon.

berkus commented 7 months ago

Ok, we don't plan to fix this immediately, but this should be a fairly easy change to do it yourself.

hcossio commented 7 months ago

just make the participantSid attribute as Optional. It is located in Models -> CoreData -> ConversationsApp -> Entities (PersistentMessageDataItem) click on participantSid and on the right panel click on Optional. Save. Run.