twilio / voice-quickstart-android

Quickstart app for the Voice Android SDK
https://www.twilio.com/docs/api/voice-sdk/android/getting-started
MIT License
184 stars 140 forks source link

App Manifest Permissions #526

Closed D-I-S-C closed 2 years ago

D-I-S-C commented 2 years ago

Why is the android.permission.FOREGROUND_SERVICE the only permission declared in the app's Manifest.xml whilst the application is making use of others like AUDIO_RECORD?

I thought looking at the Android documentation that all permissions need to be declared in the Manifest.

kbagchiGWC commented 2 years ago

@D-I-S-C We do not need to include AUDIO_RECORD permissions in the app manifest because it is inherited from Twilio Voice Android SDK manifest.

D-I-S-C commented 2 years ago

@kbagchiGWC I see - thanks for the clarification! Is there documentation from Twilio on the permissions that are inherited from Twilio Voice Android SDK?

kbagchiGWC commented 2 years ago

We don't have any documentation explicitly for this.

D-I-S-C commented 2 years ago

Ok, no worries, thanks!