search

twolfson / google-music-electron

Desktop app for Google Music on top of Electron
The Unlicense
262 stars 40 forks source link

Create desktop entries for each platform #2

Open twolfson opened 9 years ago

twolfson commented 9 years ago

It would be nice to provide a .app for OSX, a .desktop for Gnome, and handle Windows installations. This should be usable by a non-technical user.

t3rminus commented 9 years ago

I'll help! This app is fantastic! I'm working on some packaging scripts. Not sure how you want to integrate them. Should I just create a pull request and add them to an npm command?

I've also made a main app icon (concept attached), and fixed #7 while I was at it. icon_128x128 2x

twolfson commented 9 years ago

Great! It's always nice to have more help =)

Yea, feel free to open a PR. It usually helps to talk over code.

The icon looks great. Is there any licensing we have to worry about for it?

t3rminus commented 9 years ago

No licensing issues for the icon-- I made it entirely in illustrator, and will add the SVG sources to the repo. It just occurred to me though, that since the "headphones" are (intentionally) pretty much spot-on with the actual logo, there might be trademark issues involved.

I'll make some quick adjustments, and post a revised version later.

surtic86 commented 9 years ago

:+1: would be really good to see Platform Packages

t3rminus commented 9 years ago

I have a script to build for Mac. Was working on Ubuntu, but I had to move, and work's been crazy. I haven't forgotten, and I'll keep at it as soon as I get some time.

twolfson commented 8 years ago

@t3rminus started on some build scripts (although, we should have a larger discussion in here before continuing down any path). Here are some links to their work:

twolfson commented 8 years ago

Preliminary research shows that we can compile everything on Linux/OS X:

https://github.com/maxogden/electron-packager/tree/v5.2.0#building-windows-apps-from-non-windows-platforms

We likely will only need to build a .app, .exe, and executable to start as that's part of what Atom offers:

https://github.com/atom/atom/releases/tag/v1.4.0-beta3

After that, we can build a .deb and .rpm but this is to make it more iterative than all at once.

twolfson commented 8 years ago

Before taking on this task, we should figure out what to do for things like install-mpris. I would prefer to switch to a JS based solution (e.g. https://github.com/sidorares/node-dbus) but there is no MPRIS interface to a JS DBUS =(