twopointzero / TJAPlayer3

TJAPlayer3 is a rhythm game application for Windows (and compatible environments). It provides a style of gameplay very similar to that of Taiko no Tatsujin and similar rhythm games, and supports .tja files compatible with a number of other similar rhythm game applications. Download the latest release here: https://github.com/twopointzero/TJAPlayer3/releases
MIT License
158 stars 152 forks source link

Replace STAUTOPLAY with a simple flag #19

Open twopointzero opened 4 years ago

twopointzero commented 4 years ago

Can you write a one-sentence description of your request? Replace STAUTOPLAY with a simple flag.

What is the current behavior? STAUTOPLAY is a structure of many members, each representing various parts of instruments no longer supported by the software. The code (that matters) always sets all of its values true or false, usually via a loop, and then the structure gets passed around and processed by indexing into its content over and over.

What is the expected behavior? Especially with the removal of viewer support, this structure and all code processing it can be replaced with the management of a simple boolean and, as it just so happens, the code that cares was already having to manage another autoplay-related boolean for that anyway, so those can almost surely be merged.

What is the motivation / use case for changing the behavior? Code complexity, maintainability, the usual. :)