search

twopointzero / TJAPlayer3

TJAPlayer3 is a rhythm game application for Windows (and compatible environments). It provides a style of gameplay very similar to that of Taiko no Tatsujin and similar rhythm games, and supports .tja files compatible with a number of other similar rhythm game applications. Download the latest release here: https://github.com/twopointzero/TJAPlayer3/releases
MIT License
158 stars 152 forks source link

Use the sixth Balloon_Breaking texture to show the balloon pop #40

Open twopointzero opened 4 years ago

twopointzero commented 4 years ago

Can you write a one-sentence description of your request? Six Balloon_Breaking textures are loaded in TextureLoader but only five are ever selected and rendered.

What is the current behavior? I have not double-checked the behaviour since spotting this in the code, but I suspect the balloon never appears to pop and rather just disappears.

What is the expected behavior? The balloon should pop instead of disappear. Check other forks as they may have addressed this.

What is the motivation / use case for changing the behavior? Not popping would be odd.

gczark commented 4 years ago

This could be skin related. If the skin is supposed to have 5 sprites and added 1 later on; without delving in the SkinConfig.ini, the added sprite is not acknowledged.

Game_Chara_Motion_Normal=13,13,12,11,10,9,8,7,6,5,4,3,2,1,0,0,13,13,12,11,10,9,8,7,6,5,4,3,2,1,0,0 is included in the config file, I think this has effect on display order of sprites.

twopointzero commented 4 years ago

It's actually simpler than that, somewhat thankfully :). The code literally loads a hard coded set of six textures and then iterates over that set with a hard coded assumption that there are only five.