twopointzero / TJAPlayer3

TJAPlayer3 is a rhythm game application for Windows (and compatible environments). It provides a style of gameplay very similar to that of Taiko no Tatsujin and similar rhythm games, and supports .tja files compatible with a number of other similar rhythm game applications. Download the latest release here: https://github.com/twopointzero/TJAPlayer3/releases
MIT License
158 stars 153 forks source link

Fix performance panel missing texture crash and memory leak #48

Closed twopointzero closed 4 years ago

twopointzero commented 4 years ago

While investigating TJAPlayer3-11 it became apparent that CAct演奏パネル文字列 was unable to handle missing txMusicName and tx難易度とステージ数 texture files, resulting in NullReferenceException and a crash. It was also failing to properly dispose of tx難易度とステージ数 textures, resulting in an unmanaged memory leak. These issues have been fixed.

Along the way, nearby code duplication was noted and a duplication-caused bug quickly noticed, resulting in the creation of #47.