search

twrecked / pyaarlo

Asynchronous Arlo Component for Python
GNU Lesser General Public License v3.0
50 stars 34 forks source link

Add slugify to setup.py's dependencies #157

Closed jamesoff closed 3 months ago

jamesoff commented 3 months ago

Without this, it's missed when installing with e.g. pip and causes import errors.

jamesoff commented 3 months ago

Example impact: https://github.com/jamesoff/simplemonitor/pull/1436

Not sure if you can see the outputs of the Actions run, but here's an example failure:

[11](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:12)
PATH="/home/runner/work/simplemonitor/simplemonitor/tests/mocks:/opt/hostedtoolcache/Python/3.11.9/x64/bin:/opt/hostedtoolcache/Python/3.11.9/x64:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" /opt/hostedtoolcache/Python/3.11.9/x64/bin/poetry run coverage run monitor.py -1 -v -d -f tests/monitor.ini -j 1
[12](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:13)
Traceback (most recent call last):
[13](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:14)
  File "/home/runner/work/simplemonitor/simplemonitor/monitor.py", line 1, in <module>
[14](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:15)
    from simplemonitor import monitor
[15](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:16)
  File "/home/runner/work/simplemonitor/simplemonitor/simplemonitor/monitor.py", line 10, in <module>
[16](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:17)
    from .simplemonitor import SimpleMonitor
[17](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:18)
  File "/home/runner/work/simplemonitor/simplemonitor/simplemonitor/simplemonitor.py", line 15, in <module>
[18](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:19)
    from .Alerters.alerter import Alerter
[19](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:20)
  File "/home/runner/work/simplemonitor/simplemonitor/simplemonitor/Alerters/__init__.py", line 5, in <module>
[20](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:21)
    from .bulksms import BulkSMSAlerter
[21](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:22)
  File "/home/runner/work/simplemonitor/simplemonitor/simplemonitor/Alerters/bulksms.py", line 9, in <module>
[22](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:23)
    from ..Monitors.monitor import Monitor
[23](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:24)
  File "/home/runner/work/simplemonitor/simplemonitor/simplemonitor/Monitors/__init__.py", line 5, in <module>
[24](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:25)
    from .arlo import MonitorArloCamera
[25](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:26)
  File "/home/runner/work/simplemonitor/simplemonitor/simplemonitor/Monitors/arlo.py", line 7, in <module>
[26](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:27)
    import pyaarlo
[27](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:28)
  File "/home/runner/.cache/pypoetry/virtualenvs/simplemonitor-4_WDDu_b-py3.11/lib/python3.11/site-packages/pyaarlo/__init__.py", line 11, in <module>
[28](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:29)
    from .base import ArloBase
[29](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:30)
  File "/home/runner/.cache/pypoetry/virtualenvs/simplemonitor-4_WDDu_b-py3.11/lib/python3.11/site-packages/pyaarlo/base.py", line 41, in <module>
[30](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:31)
    from .media import ArloBaseStationMediaLibrary
[31](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:32)
  File "/home/runner/.cache/pypoetry/virtualenvs/simplemonitor-4_WDDu_b-py3.11/lib/python3.11/site-packages/pyaarlo/media.py", line 5, in <module>
[32](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:33)
    from slugify import slugify
[33](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:34)
ModuleNotFoundError: No module named 'slugify'
[34](https://github.com/jamesoff/simplemonitor/actions/runs/10404235310/job/28812282041?pr=1436#step:9:35)
make: *** [Makefile:16: integration-tests] Error 1
twrecked commented 3 months ago

Thanks. I'm an idiot, I updated the requirements but not this.

jamesoff commented 3 months ago

No worries, took me a little while looking at it to realise that was the problem too :)