search

tylercamp / palcalc

MIT License
33 stars 5 forks source link

Program crashing upon startup #11

Closed Banaface closed 6 months ago

Banaface commented 6 months ago

CRASHLOG.zip Few details to give. Every time I open the calculator, it gives me an error loading the save (log attached). It is most likely because I am playing with a mod that increases the number of slots to 1920. Assuming this is the issue and im not being dense, then it seems like it would be a worthwhile addition, both to allow for use with the mod and future-proofing in case the palbox gets expanded in a future update. Looks like a great tool tho and I cant wait to use it!

Banaface commented 6 months ago

Just double-checked by making a new save, no issues on the new one. (Although I had to delete the old files because the program would auto select my other save, so maybe adding a way to choose saves before one is picked would also be a good idea)

tylercamp commented 6 months ago

Thanks for opening this issue and providing the CRASHLOG file, I'm able to reproduce with the save file it contains, will take a closer look later today

Will also take a look at adding a "no save selected" state to use when there's a problem loading a save

tylercamp commented 6 months ago

@Banaface The issue is caused by pals being in a container (e.g. player party, palbox, base) which can't be found inside the Level.sav file. It looks like this container has 40 slots, and while your mod increases palbox slots to 1920, I'm not aware of any built-in pal containers with a limit of 40 pals. I see a bunch of other containers with 20 slots, i.e. bases, so I don't think it's a base.

It also looks like these pals are all owned by you ("Banaface"). Do you know where you might have 40 pals stored together?

tylercamp commented 6 months ago

@Banaface This should be fixed with v1.0.2, please confirm

Banaface commented 6 months ago

Sorry, I was going to check all my containers, but power went out as soon as I got home. I'll test the new update as soon as they restore power. Thanks for responding so quickly tho!

tylercamp commented 6 months ago

Based on #12 it seems like this may be caused by butchered pals, have you done that in your save?

Banaface commented 6 months ago

Works great now! And yes, I have butchered pals, probably about the 40 that you saw.