Suggests Pals that are no longer available

[phiilu]

Thanks for this awesome tool!

I noticed that I often get suggestions of Pals that are no longer available. This could be because I have butchered them or condensed them.

For example here:

I don't have this Jetdragon anymore, because I condensed it (RIP) and now I need to breed it again.

[tylercamp]

Strange, do you get any pop ups about reading the save file when you open the app?

It should be auto-detecting changes to the save file on startup and re-read the file contents

[phiilu]

Yes you mean that one?

Also here the Jetdragon with Clumsy does not exist. Before taking the Screenshot I went back to the menu to force a save and than opened Palcalc and rerun the calculation.

I sort the Palbox by Paldex.

[tylercamp]

Hmm, I suspected that it was referencing a previously-cached version of the save from when you still had that pal, but you only have one entry in your list on the left - was this your first time running Pal Calc? Or did you re-run it later to get this result?

Some possible causes for the root issue:

• Steam save not synced locally
• A bug in the logic for detecting when the cached save data is outdated
• A bug in the logic for detecting the type of each pal container

[tylercamp]

Ah whoops, didn't notice your latest comment

Yes, that's the notification I'm referring to. If that's popping up then I suspect there's an issue with pal container type detection, can you attach the Level.sav file from your save?

[phiilu]

Sure, I had to zip it. Thanks for looking into it!

Level.zip

[tylercamp]

Forgot to mention, could you also provide the files in the "Players" folder next to the Level.sav

[phiilu]

Here you go

Players.zip

[tylercamp]

Seems like the issue is due to an incorrect assumption about how butchered pals are handled. After butchering some pals in my save file I noticed the pal instance data still associates them with my party container, but when looking at the data for that container, the list does not contain the butchered pal. Instead there are now multiple pals which reference the same slot, while the container data lists the actual pals.

The original issues #11 and #12 led to the assumption that butchered/etc. pals would be moved to some untracked container, and those pals should be ignored. Instead we should just be looking at the list of pal containers and the pals within them, and only include pals from those containers.

I'll push a fix soon

[tylercamp]

@phiilu With the new logic I'm seeing 475 "living" pals out of 2407 total pals in your save file, does that sound right? Where missing pals could be butchered/condensed

I'm also only getting paths to a Jetragon with Legend, Nimble, and Swift, i.e. you apparently don't have any living Jetragons with Runner, is that correct?

[tylercamp]

Just loaded up your save to confirm (nice base btw) and don't see any jetragon with Runner

The displayed locations for the Jetragons are also correct 👍

[phiilu]

@tylercamp yes that sounds reasonable and yes I think at that save point I did not have a Runner Jetdragon.

Awesome that you figured it out and really appreciate your work you did with Palcalc!

[tylercamp]

@phiilu Thanks! This should be fixed in v1.4.1, please close this issue once you've confirmed

[phiilu]

I tried it out and for now I did not find any problems 🎉