typemytype / drawbot

http://www.drawbot.com
Other
398 stars 62 forks source link

Support post format-3 fonts in fs.appendGlyph() #471

Closed justvanrossum closed 2 years ago

justvanrossum commented 2 years ago

Assuming fonttools-made glyph names.

justvanrossum commented 2 years ago

Hm, fonttools actually does smarter glyph name synthesys for encoded glyphs (using AGL and uniXXXX names). Perhaps this change is too simplistic.

I don't think we have access to a (cached) TTFont instance to make a glyph name -> glyph ID mapping efficiently possible.

Alternatively, fs.appendGlyph() could accept glyph ids by means of an isinstance(glyphName, int) check.

typemytype commented 2 years ago

Support indexes as int is perfect

typemytype commented 2 years ago
justvanrossum commented 2 years ago

LGTM :)