search

typemytype / drawbot

http://www.drawbot.com
Other
393 stars 61 forks source link

Some tests fail on macOS 14 #562

Open justvanrossum opened 5 months ago

justvanrossum commented 5 months ago

I didn't dig deep, but it mostly seems SVG differences.

We should ideally switch to comparing pixel renderings of SVG files, but I'm not sure of the best way to that in macOS 14 world.

Note that we should probably address this before we upgrade the CI runner to macos-14 (M1): https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

justvanrossum commented 5 months ago

We see 4 differences in PNG, 32 differences in SVG. Some of the SVG diffs are caused different representations of paths, that will likely render the same.

MacOS can render SVG natively these days, so we should compare SVG by rendering to pixels, as we already do for PDF.

For reference:

import AppKit

p = 'path/to/image.svg'
url = AppKit.NSURL.fileURLWithPath_(p)
img = AppKit.NSImage.alloc().initByReferencingURL_(url)
image(img, (100, 100))