typo3-themes / themes

STABLE: Theme selector for TYPO3 frontend
http://www.typo3-themes.org/
36 stars 27 forks source link

TYPO3 11 compability with EXT:gridelements containers #306

Open nwm-dev opened 1 year ago

nwm-dev commented 1 year ago

After upgrading an EXT:themes and EXT:theme_bootstrap4 based project to v11, we have some problems with existing grid element containers.

Before: before

After: after

Once you save the container, at least the error messages are gone (my gut feeling tells me that there is some outdated/mismatched value in the DB for this tt_content entry causing this error), but still, the different sections are missing some options and the layout is broken.

If it helps: If I know how/why this happens, I can try to fix it and create a PR but I have absolutely no clue where I would have to check in first place (didn't work with an EXT:themes based project before). Or maybe we are missing some breaking migration. Any feedback appreciated.

kaystrobach commented 1 year ago

Hi, thank you for your report.

Can you please provide the output of composer show|grep themes and composer show|grep grid

Is the theme that you are using open source - or can you provide it?

Thanks

nwm-dev commented 1 year ago

composer show|grep themes:

typo3-themes/theme-bootstrap4              dev-typo3-11-compatibility fe93bef
typo3-themes/theme-bootstrap4-child        1.0.0
typo3-themes/themes                        dev-typo3-11-compatibility aeb1502`

composer show|grep grid:

gridelementsteam/gridelements              11.0.0

The ext_emconf.php of the child extension has comments saying it was auto generated with www.fluid-template-manager.de (I just checked and the website is not available any longer) and I assume it had been adapted to fit the project's needs. I would have to ask for permission to share the child extension privately as it is not publically available. With the given info, can you already guess if the problem is rather within the child extension or this one?

kaystrobach commented 1 year ago

I will try to reproduce it and then provide an info.

kaystrobach commented 1 year ago

btw. have you switched from BS3 to BS4 package? They do not share all the same options

nwm-dev commented 1 year ago

btw. have you switched from BS3 to BS4 package? They do not share all the same options

At least not willingly. From what I remember I only replaced the outdated EXT:themes and EXT:theme_bootstrap4 with the mentioned compability branches and had to move some import locations in the scss (because the child extension was moved from /public/typo3conf/ext/ to /packages). This comes from an update of the project from TYPO3v9 to TYPO3v11.

nwm-dev commented 1 year ago

I couldn't wait longer so I fixed this error myself but I don't know if there are any consequential errors. I will provide a PR in the next days

kaystrobach commented 1 year ago

Happy to see your PR