ndtv.com{Ads}

[ghajini]

URL(s) where the issue occurs

1. https://khabar.ndtv.com/news/bollywood/total-dhamaal-box-office-collection-day-27-ajay-devgn-anil-kapoor-madhuri-dixit-blockbuster-record-2010671?pfrom=home-topstories

2. try news at these ndtv.com sports.ndtv.com gadgets.ndtv.com food.ndtv.com swirlster.ndtv.com

Describe the issue

1. what went wrong currently(with default settings) block of taboola.com hides some legit news stories at bottom of page

2 how the page should be there should be no hide of legit content provided by taboola....also there should be blockage of sponsored ads by taboola

3. what steps you have done in order to solve problem also in order to unbreak news content at bottom of page if i allow taboola.com it brings back sponsored ads as well alongwith unblocking news content

Screenshot(s)

1.

how the page looks with default settings https://user-images.githubusercontent.com/20338483/54755250-76882400-4bdd-11e9-9855-5736288dfc7f.jpg

2. You need to allow taboola in order to see news content at bottom of page but this invites sponsored.ads as well https://user-images.githubusercontent.com/20338483/54755360-b64f0b80-4bdd-11e9-81e0-629bfb65e672.png

Versions

• Browser/version: firefox android 66
• uBlock Origin version: 1.18.6

Settings

• uBO's default settings pls try indian ip if you can't reproduce....

  Notes

issue you can reproduce on mobile device only i.e. firefox android

@Alex-302 adguard browser extension for firefox android also suffers from this breakage @jspenguin2017 @okiehsch

[jspenguin2017]

I can't test on that setup.

[okiehsch]

Me neither.

[kulfoon]

I confirm the both issues (breakage with blocked taboola.com & "Sponsored / Promoted Links" with unblocked taboola.com):

screenshoot


Try these example fixes to hide the sponsored/promoted links: ndtv.com##.attribution-disclosure-link-hybrid ndtv.com##.attribution-disclosure-link-sponsored

In case anybody interested, the sponsored/promoted links are generated by this script: http://cdn.taboola.com/libtrc/ndtv-khabar/loader.js

[Alex-302]

taboola.com hides some legit news stories at bottom of page

It seems it is blocked by our AdGuard Tracking Protection filter. Need more detailed info.

[ghajini]

@Alex-302 Sorry sir IAM not pragrammer STR. Is already given .. Go here

1. Eg https://www.ndtv.com/entertainment/these-adorable-pics-of-taimur-are-the-perfect-cure-for-your-holi-hangover-2011371?pfrom=home-lateststories

2. Unblock taboola in order to display legit news content ......

3. Reload page

4. This is ad https://user-images.githubusercontent.com/20338483/54829547-8d4a7b80-4cae-11e9-9e9a-eebfc7853065.png

5.this is legit news content https://user-images.githubusercontent.com/20338483/54829621-b4a14880-4cae-11e9-9eb5-cbfa3602e82a.png

[Alex-302]

@ghajini which filter causes it?

Sorry sir IAM not pragrammer

just fill the template:) https://github.com/AdguardTeam/AdguardFilters/issues/new

[ghajini]

@Alex-302 issue opened here https://github.com/AdguardTeam/AdguardFilters/issues/31432

[ghajini]

@mapx-, @okiehsch, @jspenguin2017 Indian ip and and Firefox desktop browser

https://www.ndtv.com/india-news/lok-sabha-elections-2019-rahul-gandhi-says-surgical-stike-on-poverty-day-after-rs-6-000-a-month-prom-2013020?pfrom=home-topscroll

This is reproducible on desktop browser also Check Firefox with ublock origin enabled and disabled....... I see hidden stories with ubo enabled....... With ubo disabled, I see continuously loading legit stories at bottom of page

[mapx-]

@ghajini test these filters

@@||cdn.taboola.com/libtrc/$script,domain=ndtv.com
@@||trc.taboola.com/ndtv$script,domain=ndtv.com

[ghajini]

I see sponsored ads by taboola..'' https://www.ndtv.com/india-news/niti-aayog-official-gets-poll-body-notice-for-comments-on-congress-scheme-2013388?pfrom=home-topscroll

Page served on my side- https://pastebin.com/2UUxQi3y

[mapx-]

save the page (html + folder) zip them together, upload on some server, send me the upload link (you still have that email I guess)

Are you talking about right side ads, in the middle etc ?

[ghajini]

I don't see ads on Firefox desktop browser...... Sorry ,I can't save page on Firefox android, there is no option like that on Firefox android nor any addon that can do that.... https://user-images.githubusercontent.com/20338483/55060723-f7c23980-5069-11e9-81e4-b678e8b6923a.jpg https://user-images.githubusercontent.com/20338483/55060731-06a8ec00-506a-11e9-9345-9f272b021620.jpg https://user-images.githubusercontent.com/20338483/55060772-26401480-506a-11e9-860b-e0d666680b86.jpg Ads are all over page, in between articles

[mapx-]

Sponsored links by taboola is text or an image ?

[mapx-]

test ndtv.com##.trc-content-sponsored

[ghajini]

When I click on them this appears ....blocked by adguards mobile filter https://user-images.githubusercontent.com/20338483/55063084-22fb5780-506f-11e9-96d9-845b072ba40b.png

https://user-images.githubusercontent.com/20338483/55063169-4d4d1500-506f-11e9-8f54-b9a815bb47e2.png

https://user-images.githubusercontent.com/20338483/55063200-63f36c00-506f-11e9-81cd-181a6e6fc6df.png

[mapx-]

ok, did you test the filter above ?

[ghajini]

I just tested ... Filter is.needed https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-477042545

everything related to ads are hidden....but filter in AdGuard Mobile Ads filter (enabled default in ubo) blocks articles from loading at (bottom of page artcles) https://user-images.githubusercontent.com/20338483/55096522-02082600-50b2-11e9-882e-bae8bdce6cd7.jpg

Do we have any solution other than whitelisting like defusing taboola through scriptlets or any other?

[kulfoon]

mapx: https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-477042545 mapx: ok, did you test the filter above ?

Me did, they're working partially - for some links, but for some links not, just like my filters mentioned here: https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-475530307, so the both solutions are complementary:

kulfoon's solution's screenshoot


mapx's solution's screenshoot


ghajini : Do we have any solution other than whitelisting like defusing taboola through scriptlets or any other?

That was the purpose why I posted the script https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-475530307 which is responsible for creating the sponsored/promoted links, in case of anyone interested in creating an inject as an alternative way to solve the issue, if necessary of course (as whitelisting is generally the preferred solution).

[mapx-]

I added the filter above, do you still see ads in the middle ? or are you @kulfoon talking about promoted stuff on the right side ? are all of those links / sections real ads or only self-promoted parts ?

[mapx-]

( @ghajini if you want to catch my/our attention don't simply replace your last comment with something else, better add a new comment)

[mapx-]

Now the trc.taboola.com scripts are whitelisted for ndtv, do you still need the images too ? @@||trc.taboola.com/ndtv-ndtvmobile/$image,domain=ndtv.com

[kulfoon]

mapx : or are you kulfoon talking about promoted stuff on the right side ? are all of those links / sections real ads or only self-promoted parts ?

Yea, I was talking about the promoted links, I thought it was the same thing like the sponsored links, but sorry, now I'm not sure anymore...best to wait for ghajini to answer.

[ghajini]

I added https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-477488484 filter & offcourse updated all filters Still.I can't access articles at bottom of page that were unblocked by taboola filter.... https://user-images.githubusercontent.com/20338483/55168304-828a5d80-516a-11e9-97bf-171249129ee6.png

https://user-images.githubusercontent.com/20338483/55168381-a0f05900-516a-11e9-994b-3855d7c29465.png

due to adguard mobile ads filter...'. 🤗@kulfoon thanks for your contributions, I see no ads as.of now those were legit....what you see like sentence sponsored /promoted links by taboola is a placeholder.not a ad

[mapx-]

@ghajini try: @@||trc.taboola.com/ndtv-ndtvmobile/$image,xhr,domain=ndtv.com

[ghajini]

Nope still I see warning.... Something like this @@||trc.taboola.com/ndtv-ndtvmobile/log/*$domain=trc.taboola.com Unblocks articles for me. ..... I don't know if this adds tracking Can't we noop these connections, I see similar taboola filter.in unbreak list for cnet

[mapx-]

Are all those requests trc.taboola.com/ndtv-ndtvmobile/log/ only images ? png ?

[mapx-]

if images and png try ||trc.taboola.com/ndtv-ndtvmobile/log/*$image,redirect=2x2-transparent.png,domain=trc.taboola.com

[ghajini]

From logger what I see it originates as type doc You can check yourside, subscribe to adguard mobile ads filter on.desktop browser then click on bottom articles No that filter doesn't help

[ghajini]

Firefox android

New ads appeared at bottom of page....this appears after page load.....in between articles at bottom navigation bar from left to.right https://prnt.sc/n496h2 http://prnt.sc/n498wd

[mapx-]

did you test ndtv.com##.composite-branding.branding ?

[mapx-]

or ndtv.com##.composite-branding.branding:has-text(/sponsored/i):xpath(..)

(I get no such sponsored stuff, so you have to test the filters)

[ghajini]

Tested ndtv.com##.composite-branding.branding:has-text(/sponsored/i):xpath(..) working finally.....

Just thought - Pretty nasty stuff taboola and Colombia

[ghajini]

Fix doesn't work here https://www.ndtv.com/india-news/lok-sabha-elections-2019-have-support-from-congress-says-bjps-nitin-gadkari-ahead-of-polls-2013902?amp=1&akamai-rum=off&amp_js_v=0.1&usqp=mq331AQECAEoAQ==

[mapx-]

which one ? and means what ? still ads ? which ads ?

[ghajini]

No ads.....articles hidden

[mapx-]

mobile or desktop ?

[ghajini]

Now on Firefox android 66 Ublock origin 1.18.14 Will give you feedback tomorrow morning

[mapx-]

test @@||trc.taboola.com/ndtv-ndtvmobile/log/$image,domain=ndtv.com

[ghajini]

No that doesn't work...... Firstly I have to do some work in order to unblock articles

1. Whitelist ampproject in order to see taboola 2.whitelist taboola and as well as no cosmetic filtering for site because there are cosmetic filters in adguards mobile ads filter for taboola

2. Then you see articles unblocked

3. This offcourse invites sponsored ads

Note- your previous fixes doesn't work for https://www.ndtv.com/india-news/lok-sabha-elections-2019-have-support-from-congress-says-bjps-nitin-gadkari-ahead-of-polls-2013902?amp=1&akamai-rum=off&amp_js_v=0.1&usqp=mq331AQECAEoAQ== Interestingly this works for another URL for mentioned in original threads

PAge served on my end https://pastebin.com/1TfzzRiY

[mapx-]

test

@@||cdn.ampproject.org/*amp-ad$script,domain=ndtv.com
@@||cdn.taboola.com/libtrc/ndtv-ndtvmobile/loader.js$script,domain=ampproject.net
@@||cdn.taboola.com/libtrc/impl.$script,domain=ampproject.net
@@||trc.taboola.com/ndtv-ndtvmobile/$script,domain=ampproject.net
ndtv.com#@#amp-embed[type="taboola"]

[ghajini]

Sponsored ads

[mapx-]

I cannot reproduce on desktop (tried 3 user agent switcher)

[ghajini]

Yeah require android device with Firefox browser android Whom among contributors have android device?..... @gwarser @gorhill

[gwarser]

This is not ad?

Must be mislabeled, because is hidden by ##.trc-content-sponsored

[ghajini]

In your screenshot clearly I see manuka feed sponsored links which is ad, below which (deepika......) is legit.... Which URL, I will check..... By the way check this https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478133586 https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478206104

[kulfoon]

ghajini:

Yeah require android device with Firefox browser android Whom among contributors have android device?.....

How many times need to repeat... https://github.com/uBlockOrigin/uAssets/issues/3482#issuecomment-433596075 + https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode

[gwarser]

For now https://addons.mozilla.org/android/addon/amp2html/

---

Responsive Design Mode in Firefox works just fine. You may only need to select real device from list (there is more under "Edit List")

---

Side note - for me, this page works good enough.

[mapx-]

@gwarser

You mean needing the filters above https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478217396

or does work without them ?

[gwarser]

Default settings. On HTML page sometimes legit (? Deepika) links are hidden, on AMP taboola thumbnails are not shown at all.

[kulfoon]

BTW at the link OP gave: https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478133586 / https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478206104 I get some empty ad containers and labels on Firefox Desktop and Opera (both with and without https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478217396 ), so unrelated):

spoiler