Closed reaper666735 closed 2 years ago
- [X] I verified that this is not a filter issue (MUST be reported at filter issue tracker)
How did you verify this?
@reaper666735 did you change user agent? return native and look.
Are you sure you didn't use element zapper instead?
@g0blin-NN did not change anything except the update'd UB lol
@Nojuuu oh i'm very sure i used the "Element picker" ....
Did you check that the element might have a randomly generated class at each reload? You need to make the case you know the issue is not a filter one, hence why I ask how did you rule out it's not a filter issue. Without this, the issue will be closed as invalid.
Also, "Waterfox G4.0.7" is not a supported browser, I have no idea on what version of Firefox it's based on and neither whether there are changes in it which breaks uBO.
I use Firefox stable 97 and I could pick and remove the sidebar on the right using the filter:
outlook.live.com##._1dBL6mV6xRANqjh_Z8BjN6 > ._1fti_QgAzqGWPGlqh_FSvI
No issue upon reload of the page -- using default settings/lists.
it's based on Gecko from Firefox, release notes say it's on version 91.6 of that engine
also as i stated when i revert back to 1.40.8 i have no more issue ?, if it really was the random generated class as you suggested
as i stated when i revert back to 1.40.8 i have no more issue ?
As stated, no issue with Firefox stable, so try with Firefox stable, Waterfox is not officially supported.
G4.0.6 (64-bit) works fine here (does not update to .7). I tried hiding some stuff on YT - it works. Promoted posts on Reddit hidden too.
I'm having the same issue on both Firefox and Waterfox. My filters no longer work after updating uBO, but the default filter lists do still work.
EDIT: Downgrading to 1.40.8 fixes the issue
Is "My filters" selected on "Filter lists" tab and shows how many filters are used?
Is "My filters" selected on "Filter lists" tab and shows how many filters are used?
Yes, both are true. But the weird part is that after updating back to 1.41.2, my filters now work and persist even after a restart. So whatever the problem is, it's fixed by downgrading then re-updating. No clue how or why that happens, but it works now so ¯_(ツ)_/¯
EDIT: now it's back to not working, so I'm sticking with the older version for now
in a weird way i'm happy i'm not the only one to report it now lol, i was feeling like it just had to be me ......
I have the same issue with Firefox. In addition to custom filters not working, promoted content on Reddit and some YouTube ads will also start appearing when the bug is triggered, at least for me. I noticed that if I purge all caches and then update all filters, my custom filters will start working and all ads should be gone. However, they will randomly stop working again after some time and I don't know exactly what triggers it. I can confirm that downgrading to 1.40.8 fixes the issue.
FF 78.15 ESR on Windows 7 Pro SP1 x64. UA: "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0"
After update uBO 1.40.8 to 1.41.2, the floating glitch also occurs - "My Rules" are ignored. There are no records of the "My Rules" in Logger. Temporarily fix - in settings turn off checkbox "My Rules" -> click "Apply Changes" -> turn on checkbox "My Rules" -> click "Apply Changes". After that, "My Rules" begin to work and in the logger there are appropriate records.
Rollback to version 1.40.8 completely solves the problem.
There are no records of the "My Rules" in Logger.
I gather you mean "My filters".
From what I read, this suggests a specific cosmetic filter is being problematic -- quite possibly a highly generic one. It would be useful to share your custom filters for those suffering the issue.
In uBO 1.41.2, highly generic cosmetic filters are wrapped into :is(...):not(html,body)
, where ...
is the highly generic cosmetic filters, and this is done so as to fix https://github.com/uBlockOrigin/uBlock-issues/issues/1692. Now I wonder whether a particular cosmetic filter is incompatible for being wrapped into :is(...):not(html,body)
-- which by the way happens only for Firefox 84+.
So bottom line, I need information about your custom filters if this issue is to go forward.
@gorhill https://github.com/DandelionSprout/adfilt/issues/63#issuecomment-1038135518 maybe related?
@Nojuuu very bad regression, breaks uBO(my filters goes 0 out of 0) and blocks all network connections to any site alltogether(unable to browse any website). This warrants an emergency fix.
@gorhill
This is not a regression, this has always been in there, it just needed a argument-less removeparam
filter to expose the problem.
Actually, the conditions that had to be all reunited for the error to manifest:
removeparam
I don't see any such instance of filter in either uBO filter lists, nor "Actually Legitimate URL Shortener Tool", nor "AdGuard URL Tracking filter". So although a bad issue warranting an emergency fix, it's not affecting majority of users.
Also, probably unrelated to the actual issue filed here.
Maybe poor filterlist used @@*$ehide
and user don't saw this (no check commits or use logger).
Also may have enabled A/B Test with very unstable classes in dom tree/nodes - then filter no longer match after refresh.
@krystian3w that doesn't explain why the problem disappears when a user drops down to 1.40.8.
There was another instance on reddit just now: https://www.reddit.com/r/uBlockOrigin/comments/srmcy6/paradox_interactives_featured_content_antifeature/
Hi, I'm the reddit poster who raised the issue the user above just linked to.
The entirety of my ruleset is:
! 11/06/2019 https://forum.paradoxplaza.com
forum.paradoxplaza.com###\#pdx-cookie > .pdx-cookie--toggle.pdx-cookie-bottom-bar__toggle
! nuke paradox's stupid space-wasting featured content area
forum.paradoxplaza.com##.thfeature_featuredGrid
forum.paradoxplaza.com##h3.block-header
and I'm using Firefox ESR 78.12.0esr (64-bit) on Linux.
1.40.8 may also fail if page have enabled A/B Test to use new names after refresh.
-cookie
IMO paradox plaza need accept cookies instead only hide or remove by :remove()
.
IMO paradox plaza need accept cookies instead only hide or remove by
:remove()
.
The issue was with the featured grid filter, though.
Better teach about GDPR breakges.
Yeah, the thing to permanently suppress their intrusive cookie button (the little bottom-of-window widget appears even if you're logged in and have accepted cookies!) worked fine.
@gorhill when you mentioned needing our custom filters are you referring to "My Filters" or the filter lists "Custom" tab ?
CSS specifity form custom subrcribied file also may disable filter after refresh - but on 1.40.8 tested without import settings?
when you mentioned needing our custom filters are you referring to "My Filters" or the filter lists "Custom" tab ?
To reproduce your setup he needs your filters and troubleshooting information from support tab
I have same issues on firefox. very few simple filters, they get randomly ignored. sometimes reloading fixes, but most if time I need to delete them, save the empty custom filters, and re-add them. they are all about fixed class/id elements, no random id/class name generated, simple static filter, like:
website.com##div:nth-of-type(8) mygame.fandom.com##.top-ads-container
There are no records of the "My Rules" in Logger.
I gather you mean "My filters".
Yes, of course. "My filters", you right.
From what I read, this suggests a specific cosmetic filter is being problematic -- quite possibly a highly generic one. It would be useful to share your custom filters for those suffering the issue.
In uBO 1.41.2, highly generic cosmetic filters are wrapped into
:is(...):not(html,body)
, where...
is the highly generic cosmetic filters, and this is done so as to fix #1692. Now I wonder whether a particular cosmetic filter is incompatible for being wrapped into:is(...):not(html,body)
-- which by the way happens only for Firefox 84+.So bottom line, I need information about your custom filters if this issue is to go forward.
My filters is very easy:
! **hide posts blacklisted users on forum.ixbt.com**
! forum.ixbt.com##.column.left > table[id^="post"][onmousedown^="selected_name="][onmousedown*="nickname"]
forum.ixbt.com##.column.left > table[id^="post"][onmousedown^="selected_name="][onmousedown*="'77'"]
forum.ixbt.com##.column.left > table[id^="post"][onmousedown^="selected_name="][onmousedown*="%u0411%u0440%u0443%u043D%u043E%20%u0424%u0435%u0440%u0440%u0430%u0440%u0438"]
forum.ixbt.com##.column.left > table[id^="post"][onmousedown^="selected_name="][onmousedown*="%u042D%u0440%u0435%u0448%u043A%u0438%u0433%u0430%u043B%u044C"]
forum.ixbt.com##.column.left > table[id^="post"][onmousedown^="selected_name="][onmousedown*="%u0428%u0438%u043C%u043E%u043D"]
forum.ixbt.com##.column.left > table[id^="post"][onmousedown^="selected_name="][onmousedown*="%u042F%u0441%u043D%u044B%u0439"]
forum.ixbt.com##.column.left > table[id^="post"][onmousedown^="selected_name="][onmousedown*="user2f"]
! **trash on https://forums.overclockers.ru/**
forums.overclockers.ru###wrapcentre > table:nth-of-type(2) > tbody > tr > td:nth-of-type(2)
! **fix for panopticlick.eff.org**
@@||panopticlick.eff.org/static/fp2.js|$script,domain=panopticlick.eff.org
! **popup notifications on https://translate.google.com/**
translate.google.com##.notification-area > .tlid-notification-container.notification-container
! **trash on yandex**
yandex.by,yandex.kz,yandex.ru,yandex.ua,yandex.uz##body[class*="logged "][class*=" b-page_"] div[class*="media-grid"][class*="media-content"]
! **fix for boxberry.ru**
@@/tracking/get?$domain=boxberry.ru
For reference, the main filters I noticed that broke with the update: www.reddit.com##.premium-banner youtube.com##.ytp-ce-element-show
EDIT: and yes I've tried youtube.com##.ytp-ce-element - that's not the problem
Try delete -show
.
Hello everyone,
I had the same problem. v1.41.2 ignores "my filters". I haven't tried much, but for example this filter doesn't work anymore: "www.zdf.de##.b-live-tv" So I switched back to v1.40.8 and it's fine.
Today I switched from FF 78.15 ESR to the current version 91.6 ESR and also updated uB to v1.41.2
Now it works without problems... Maybe this information will help.
Let's see if this comment leads anywhere: https://www.reddit.com/r/uBlockOrigin/comments/srmcy6/comment/hx0ky2z/
Maybe it's the Defender messing with browser storage?
For me rare no works generic to hide social share in disqus frames, but filter specified by domain also no help and this looks like bug with iframes about:blank.
I seem to have fixed the issue, at least for myself:
Create a new profile -> Install uBlock -> Test -> Works as intended.
Return to original profile -> Test -> Does not work as intended.
Disable/Reset options until it works.
You probably only need to clear cache/update, but I listed all my steps for completeness.
Edit/Update: Noticed that uBlock was not working on reddit again, purge cache -> update -> reload again 'fixed' the issue.
So Firefox version appears important, so whoever has reported having the issue, please disclose your browser version.
I am on firefox ESR 78.15.0
well from seeing the comments id say FF 78 seems to be an average, but i thought the latest update upped the min. to 68 only ?, maybe something on that end is doing something screwy ?
and once again i'm on Waterfox but it could be somehow it might be related to that version more then we might realise
i thought the latest update upped the min. to 68 only ?
Yes, but there seems to be an unforeseen issue, which is what we are trying to narrow.
Looking at the code, there is a bit of a race condition in Firefox-based browsers, whereas uBO assumes the browser version to be 91, while waiting for the real version number to come through a promise. However I find it difficult that filter lists would be compiled before the promise is fulfilled, as it is one of the first thing uBO does at launch.
At this point I am contemplating seriously to revert https://github.com/gorhill/uBlock/commit/7c8aec250f03580bbd761810bf5bf26d277683b0 -- I have a strong suspicion the issue might be related to this -- and bring back the commit in a subsequent dev cycle with more testing being done (please use the dev build if you want such issues to be found before stable release).
I need to correct myself here -- this has nothing to do with compiling, but it's rather at injection time of highly generic cosmetic filters. In any case, it's even more unlikely that uBO wouldn't know the real browser version at that point.
i guess we will just have to wait and see (test) if that will fix it :p
A commit which might be at the root of the issue here has been reverted, and the change is available in 1.41.5b1 or above. I will wait for feedback as to whether this makes a difference or not. If the issue does not appear to be there after installing 1.41.5b1+, probably best to use that dev build for a while before immediately concluding it's fixed.
just doing a quick test on several sites i have filters on does seem to show 1.41.5b1 to be working as it should again :), ofc i will keep testing wit this build and keep you informed should anything happen ;)
A commit which might be at the root of the issue here has been reverted, and the change is available in 1.41.5b1 or above. I will wait for feedback as to whether this makes a difference or not.
Install version 1.41.5b1 on FF 78.15 ESR. The problem no longer arises. "My filters" works. Thanks!
Prerequisites
I tried to reproduce the issue when...
Description
since the latest update items i choose in the element picker mode (who end up in my filter list) are not being hidden anymore, reverting back to 1.40.8 fixes this issue
A specific URL where the issue occurs
https://outlook.live.com/mail/inbox
Steps to Reproduce
Expected behavior
well i expected it to be hidden even after reload :p
Actual behavior
it seems to stay as long as you don't leave the page, otherwise it seems to not load from my filter list
uBlock Origin version
1.41.2
Browser name and version
Waterfox (G4.0.7)
Operating System and version
win 10 21h2