ualbertalib / NEOSDiscovery

Blacklight instance for the NEOS library consortium retired December 22, 2022
https://catalogue.neoslibraries.ca
4 stars 2 forks source link

Address regression from rails 5.2.8.1 upgrade impacting serialization the Search model #613

Closed jefferya closed 2 years ago

jefferya commented 2 years ago

Rails 5.2.8.1 necessitated the specification of permitted classes as part of https://discuss.rubyonrails.org/t/cve-2022-32224-possible-rce-escalation-bug-with-serialized-columns-in-active-record/81017

This PR addresses the regression from the Rails 5.2.8.1 upgrade impacting storage of ActiveSupport::HashWithIndifferentAccess yaml serializations (that impacts the Search model in Blacklight).

From @pgwillia via Slack @ 2022-07-20:

Blacklight has a "fix" that they even backported to the 6.x version we're using which deems ActiveSupport::HashWithIndifferentAccess and Symbol as "safe" classes for serialization. Unfortunately we're stuck on blacklight 6.10.1 because newer versions introduce a bug in how our email form is presented.