update go-statsd-client to v5

uber-go / tally

A Go metrics interface with fast buffered metrics and third party reporters

MIT License

850 stars 116 forks source link

update go-statsd-client to v5 #194

Closed krrrr38 closed 1 year ago

krrrr38 commented 1 year ago

Motivation

Current go-statsd-client is too old. Dependency commit is 2years ago.

https://github.com/cactus/go-statsd-client/tree/cb0885a1018c53bc05535cfbbd1fb858430b9f8c

Discussion

It has a breaking change on func NewReporter(statsd statsd.Statter, opts Options) tally.StatsReporter.

Upgrade guide is just change like a following.

-   "github.com/cactus/go-statsd-client/statsd"
+   "github.com/cactus/go-statsd-client/v5/statsd"

CLAassistant commented 1 year ago

All committers have signed the CLA.

nitrocode commented 1 year ago

@brawndou @SokolAndrey please review when time permits. We'd like to see this dependency upgrade get merged in to keep our code base using the latest dependencies

nitrocode commented 1 year ago

@artms @abhinav @brawndou friendly ping. Please review 🙏

abhinav commented 1 year ago

Apologies, @nitrocode, I don't work at Uber anymore and don't have maintainer privileges in this repository. I've messaged some folks there to see if they can find someone to look at this.

nitrocode commented 1 year ago

Thank you @abhinav @mway and @brawndou for getting this over the line.

And thank you to @krrrr38 !

Looking forward to v3.5.4. Is this release planned today too? 🙏

nitrocode commented 1 year ago

Thank you! I see the latest version is 4.1.7. we'll upgrade to 4.x.