uber / h3

Hexagonal hierarchical geospatial indexing system
https://h3geo.org
Apache License 2.0
4.85k stars 459 forks source link

Prevent signed integer overflow in maxGridDiskSize #686

Closed isaacbrodsky closed 2 years ago

isaacbrodsky commented 2 years ago

Signed integer overflow is undefined behavior in C, so we cannot add, multiply, etc. arbitrary integer inputs. This adds a hard cap on the maxGridDiskSize function based on knowledge of the grid system itself.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.003%) to 99.038% when pulling a0c4bbe5a97741cec0813687071518fcf21fa46f on isaacbrodsky:prevent-signed-integer-overflow-maxgriddisksize into f581626150e2e2b02f0ee1636084dfb8a4563abf on uber:master.