search

uber / h3

Hexagonal hierarchical geospatial indexing system
https://h3geo.org
Apache License 2.0
4.92k stars 468 forks source link

ratio for calculation of bbox area should always be > 1 (#708) #710

Closed sebisteiner closed 1 year ago

sebisteiner commented 2 years ago

Description and discussion is here: https://github.com/uber/h3/issues/708

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.0008%) to 98.994% when pulling 648220404ba8e5e48c04f956ea6c5537d9b401f9 on sebisteiner:feature/ses/bbox-estimate into 0d450072aac1b25d7b130150df923c3403ac7673 on uber:master.

isaacbrodsky commented 2 years ago

Hi, could you rebase now that #711 is merged? Essentially that PR adds an if check for either diff being zero.

Also, are you able to suggest some tests to validate this change?

sebisteiner commented 2 years ago

Hi, could you rebase now that #711 is merged? Essentially that PR adds an if check for either diff being zero.

Also, are you able to suggest some tests to validate this change?

Done 👍

sebisteiner commented 2 years ago

@nrabinowitz I made two errors in my unit test 😢 Will fix it later today.

sebisteiner commented 2 years ago

@nrabinowitz Done. Sorry for the inconvenience.