Closed mciethan closed 1 year ago
This looks great, thanks for the contribution! I'll let @ajfriend check the approach here, but it LGTM. I believe you're correct that all we would need to do in code is modify the hard-coded values, feel free to add that to this PR.
Sounds good, I went ahead and updated the hard-coded average edge length values in my latest commit. I rounded all values to 10 significant digits, as the original code does.
Looks good to me! And just as a quick sanity check, I made a plot with the interpolated values:
I recomputed average edge lengths for all H3 resolutions, building off of the proposed methodology and example notebook provided by @ajfriend in #666 (which involves calculating exact averages for resolutions 0 through 6 and then extrapolating the rest). This would help fix #526 and other issues related to average edge lengths.
Source notebook: https://gist.github.com/mciethan/3e10802c1f41972831c325994d97ef27
My initial commit to this PR only modifies the restable docs. I haven't attempted to modify the average edge length function itself, although it would make sense to do that before updating the docs. I assume that would just be a matter of updating the hard-coded values, but I am a novice of H3 and also don't know any C programming, so I don't have a good understanding of exactly which files would need to be updated, how to test the changes, etc.