search

uber / h3

Hexagonal hierarchical geospatial indexing system
https://h3geo.org
Apache License 2.0
4.8k stars 457 forks source link

Fix case where parent bounding box contains hole #806

Closed nrabinowitz closed 8 months ago

nrabinowitz commented 8 months ago

This issue came up when comparing old/new output for countries: When the parent bounding box is fully contained by the outer polygon but fully contains a hole, we were still including the parent in the output. The fix is to check whether the bounding box contains a vertex of the hole, and fail fast if it does.

coveralls commented 8 months ago

Coverage Status

coverage: 98.824% (+0.002%) from 98.822% when pulling be92c3b8d0aced2569fa212298ec3b6a30debc92 on nrabinowitz:hole-fix into a61a46432aa6809b709476f53f0ac4a81723f7ef on uber:master.