search

uber / h3

Hexagonal hierarchical geospatial indexing system
https://h3geo.org
Apache License 2.0
4.8k stars 457 forks source link

Implement the cellToBoundary command for the h3 binary #818

Closed dfellis closed 5 months ago

dfellis commented 6 months ago

Just this one command at first as I remember how we had structured the arg parsing API. Tested for correctness manually, I will see if/how testing this binary was set up shortly.

coveralls commented 6 months ago

Coverage Status

coverage: 98.827%. remained the same when pulling 9d416a435afc8c55d44998a931e763c77e3a1350 on h3-cellToBoundary-cmd into a523fc65de144f4d54dbf056b13d90ae95bbf4c1 on master.

dfellis commented 6 months ago

So... I don't see any tests for the h3 binary at all. Will like to discuss with you guys how we want to test it.

dfellis commented 5 months ago

So... I don't see any tests for the h3 binary at all. Will like to discuss with you guys how we want to test it.

I finally found the tests near the bottom of the CMakeTests.cmake file, and then I updated them with the new WKT formatting and added the new test. No need to bring in more complicated machinery for these tests.