uber / h3

Hexagonal hierarchical geospatial indexing system
https://h3geo.org
Apache License 2.0
4.8k stars 457 forks source link

Use CMAKE_INSTALL_LIBDIR #819

Closed kou closed 6 months ago

kou commented 6 months ago

We always use "lib" for library directory but Debian/Ubuntu use "lib/x86_64-linux-gnu" and RHEL use "lib64" on 64bit.

CMake provides CMAKE_INSTALL_LIBDIR that abstracts system library directory. We can use it by including GNUInstallDirs. See also: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

kou commented 6 months ago

This will fix #406.

coveralls commented 6 months ago

Coverage Status

coverage: 98.827%. remained the same when pulling 279e7564c765706ed8f1ca4d6832be7a19eef90e on kou:cmake-libdir into a523fc65de144f4d54dbf056b13d90ae95bbf4c1 on uber:master.