uber / h3

Hexagonal hierarchical geospatial indexing system
https://h3geo.org
Apache License 2.0
4.8k stars 457 forks source link

Redesign the website homepage #836

Closed isaacbrodsky closed 1 month ago

isaacbrodsky commented 4 months ago

Here are some work in progress screenshots:

Screenshot 2024-05-03 at 3 08 29 PM Screenshot 2024-05-03 at 3 08 20 PM

Goals are for the h3geo.org home page to be more informative and useful.

I adapted the code from deck.gl. There is still a lot of extra abstraction that can be cleaned up and removed here. We will also need to substitute appropriate basemap keys for this website.

coveralls commented 4 months ago

Coverage Status

coverage: 98.826%. remained the same when pulling f1fe93e575f86a5baa9d5df30462a3cb75062456 on isaacbrodsky:website-deck into ecc0d254d2fcc93a8df807b21e116f942092d161 on uber:master.

ajfriend commented 4 months ago

How easy would it be to let users click on the map to select and deselect hexes? And maybe in a way that would sync with the text box of given hexes?

isaacbrodsky commented 4 months ago

How easy would it be to let users click on the map to select and deselect hexes? And maybe in a way that would sync with the text box of given hexes?

The text box and the map can certainly be synchronized to each other. Right now we need to remove a lot of deck.gl's example boilerplate to make that state code easier to follow.

Selecting and deselecting hexes is possible but depends heavily on the exact logic for the selection interaction. Maybe we could use the approach @nrabinowitz mentioned to figure out what resolution of cell to select for a click?

isaacbrodsky commented 4 months ago

@ajfriend can you look into the license/snyk check and let me know what's going on? I do not have access to that report.

ajfriend commented 3 months ago

I got added to Synk, here's what it is complaining about: Screenshot 2024-05-06 at 9 11 53 AM

I'm asking if we can have external accounts also added to Synk.

ajfriend commented 3 months ago

Oh, its "snyk". Not "synk". :/

dfellis commented 3 months ago

Now that it's building, here's some updated screenshots. :)

Screenshot from 2024-05-20 18-38-30 Screenshot from 2024-05-20 18-38-51

ajfriend commented 3 months ago

Amazing! This is super exciting, and the screenshots look great!

I'll try building locally to test things out in the next few days.

Quick thoughts just based off of the screenshots: Of the information you're displaying in each cell, I'd actually consider the following to be fairly "advanced" H3 content that the average user probably wouldn't know what to make of:

For a maximally-welcoming front-page display, I wonder if we'd want to limit it down to just the basics of what might be the most relevant to a new user:

Maybe a separate view could provide more of the advanced cell stats, or just reordering or deprioritizing the advanced stuff? Also, all this info might be fine, this is just my first impression :)

isaacbrodsky commented 3 months ago

Maybe a separate view could provide more of the advanced cell stats, or just reordering or deprioritizing the advanced stuff? Also, all this info might be fine, this is just my first impression :)

I agree these things can move off to a new page that acts as the official "index inspector". The home page should focus on:

Things that will move to another page include:

isaacbrodsky commented 3 months ago

Some notes from reviewing this live:

dfellis commented 2 months ago

I have to note that I can't really test this as it currently is with the switch to mapbox, as it needs a mapbox token to load the tiles, and the dev console reports that it's not present.

Secondarily, I'm not sure if it's related to the tiles failing to load or not, but it can never resolve my location.

Screenshot from 2024-06-26 15-09-16

Somewhat unrelated, it seems the snyk integration has broken entirely (or they've blocked me from viewing it, as the details button even for the "Public Github" fails after I log in).

isaacbrodsky commented 2 months ago

That shouldn't be related to the Mapbox failure. I believe it should run with a free Mapbox account but yes it is a limitation of using Mapbox.