uber / piranha

A tool for refactoring code related to feature flag APIs
Apache License 2.0
2.27k stars 190 forks source link

Recent maturin version and standardizing Python across GH workflows #645

Closed dvmarcilio closed 9 months ago

dvmarcilio commented 9 months ago

Changes

Tests

Context

643's pyproject.toml is only supported by more recent versions of maturin.

Currently, by running pip install maturin, we use the latest 1.4.0 version in local development, most of GitHub workflows, and in RELEASING.md. However, pyproject.toml was specifying version 0.13.0 for maturin, which raised a warning (e.g., build for #643 , build for #632):

Warning: You specified maturin >=0.13, <0.14 in pyproject.toml under build-system.requires, but the current maturin version is 1.4.0

So after #634, we had a build problem for specific ubuntu version when maturin version was indeed 0.13.0. The build problem seems to be flaky, as #634's build passed, but following ones did not. Moreover, I successfully locally built releases from macOS and another ubuntu version.

The changes in polyglot_build.yml and polyglot_release.yml aim to remove this python and python-dependencies inconsistencies.