uber / piranha

A tool for refactoring code related to feature flag APIs
Apache License 2.0
2.27k stars 190 forks source link

Remove emptied lines instead of emptying only the contents of the line #664

Open Bennet-Sunder opened 4 months ago

Bennet-Sunder commented 4 months ago

image (1)

Polyglot piranha currently empties a line instead of removing this line. This means we will have to manually delete all such blank lines post polyglot execution.

Running linters might not be straightforward on larger repositories as it might cleanup unmodified lines as well leading to a huge diff.

Bennet-Sunder commented 4 months ago

@ketkarameya could you pls assign this to me, I'll have a look at fixing this.