public String get(String requestNumberPrefix, String request) {
if (Boolean.parseBoolean(tenantConfiguration.get(TenantConfigurationKey.FEATURE_SEQUENTIAL_NUMBERS_FOR_WARRANTY))) {
log.info("request number prefix is {}", requestNumberPrefix);
Long nextSequenceId = getNextSequenceIdAndSave(requestNumberPrefix, request);
String sequenceNumber = String.format(REQUEST_NUMBER_FORMAT, nextSequenceId);
return requestNumberPrefix + sequenceNumber;
}
return generateRandomNumber();
}
its modifiying as
public String get(String requestNumberPrefix, String request) {
if (Boolean.parseBoolean(true)) {
log.info("request number prefix is {}", requestNumberPrefix);
Long nextSequenceId = getNextSequenceIdAndSave(requestNumberPrefix, request);
String sequenceNumber = String.format(REQUEST_NUMBER_FORMAT, nextSequenceId);
return requestNumberPrefix + sequenceNumber;
}
return generateRandomNumber();
}
I want to remove Boolean.parseBoolean also so my feature clean up works as expected
public String get(String requestNumberPrefix, String request) {
log.info("request number prefix is {}", requestNumberPrefix);
Long nextSequenceId = getNextSequenceIdAndSave(requestNumberPrefix, request);
String sequenceNumber = String.format(REQUEST_NUMBER_FORMAT, nextSequenceId);
return requestNumberPrefix + sequenceNumber;
Hi @danieltrt
I have below rule
[[rules]] name = "replace_isToggleEnabled_with_boolean_literal" query = """(( (methodinvocation name : () @name arguments: ((argument_list ([ (fieldaccess field: ()@argument) (_) @argument ])) )
) (#eq? @name "get") (#eq? @argument "@stale_flag_name") )""" replace_node = "method_invocation" replace = "@treated" groups = ["replace_expression_with_boolean_literal"] holes = ["treated", "stale_flag_name"]
when I apply the rule on the method
public String get(String requestNumberPrefix, String request) { if (Boolean.parseBoolean(tenantConfiguration.get(TenantConfigurationKey.FEATURE_SEQUENTIAL_NUMBERS_FOR_WARRANTY))) { log.info("request number prefix is {}", requestNumberPrefix); Long nextSequenceId = getNextSequenceIdAndSave(requestNumberPrefix, request); String sequenceNumber = String.format(REQUEST_NUMBER_FORMAT, nextSequenceId); return requestNumberPrefix + sequenceNumber; } return generateRandomNumber(); }
its modifiying as
public String get(String requestNumberPrefix, String request) { if (Boolean.parseBoolean(true)) { log.info("request number prefix is {}", requestNumberPrefix); Long nextSequenceId = getNextSequenceIdAndSave(requestNumberPrefix, request); String sequenceNumber = String.format(REQUEST_NUMBER_FORMAT, nextSequenceId); return requestNumberPrefix + sequenceNumber; } return generateRandomNumber(); } I want to remove Boolean.parseBoolean also so my feature clean up works as expected
public String get(String requestNumberPrefix, String request) {
} can you please suggest how can i update my rule