uber / react-view

React View is an interactive playground, documentation and code generator for your components.
https://react-view.pages.dev
MIT License
697 stars 41 forks source link

Upgrade `react-tiny-popover` (Fixes an issue with react and react-dom peer dependencies) #105

Closed taifen closed 10 months ago

taifen commented 10 months ago

We use npm and React 17 in our project, but @miksu/react-tiny-popover@3.5.1 adds React 16 and causes errors due to multiple React versions at runtime. So we had to add aliases for react and react-dom to the Webpack configuration. It would be nice if packages could work without them.

├── react-dom@17.0.2
└─┬ react-view@3.0.0
  ├─┬ @miksu/react-tiny-popover@3.5.1
  │ └── react-dom@16.14.0
  └─┬ react-simple-code-editor@0.13.1
    └── react-dom@17.0.2 deduped

This PR replaces @miksu/react-tiny-popover with the latest react-tiny-popover package.

Also, the contribution guidelines seem to be out of date, so I've replaced the yarn commands with ones I used but would appreciate feedback on this.

Thanks for the nice library!

changeset-bot[bot] commented 10 months ago

🦋 Changeset detected

Latest commit: 9a6fd361380e6540edffe1e4068084a8b87c269a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------- | ----- | | react-view | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR