search

uber / react-view

React View is an interactive playground, documentation and code generator for your components.
https://react-view.pages.dev
MIT License
697 stars 41 forks source link

Latest version v2.3.4 in registry.npmjs.org is different from v2.3.4 release in github #56

Open anelook opened 3 years ago

anelook commented 3 years ago

Hello,

While updating to the latest version of the library I've noticed that some of the changes are missing in the registry, https://registry.npmjs.org/react-view/-/react-view-2.3.4.tgz and https://github.com/uber/react-view/archive/v2.3.4.zip are not the same.

In particular, when you look at this file code-generator, you can see that the latest fix is not there. For a reference, here is the change that was released in v2.3.4 https://github.com/uber/react-view/blob/master/src/code-generator.ts#L110

Could you check it please?

Have a great day, Olena

tajo commented 3 years ago

I published 2.3.5, hopefully that one should be fine