search

ubie-oss / kotlin-graphql-sample

Sample implementation of Kotlin+Spring+GraphQL
https://ubie.life/
Apache License 2.0
87 stars 14 forks source link

Remove .idea/modules.xml file because it will be generated on import #3

Closed nobuoka closed 5 years ago

nobuoka commented 5 years ago

Problem

Openning this project, IntelliJ IDEA encounters an error. The error message is following:

intellij idea

Environment

IntelliJ IDEA 2018.3 (Community Edition) Build #IC-183.4284.148, built on November 21, 2018 JRE: 1.8.0_152-release-1343-b15 amd64 JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o Windows 10 10.0

Reason

The .idea/modules.xml file is under version-controlled but files referenced from the file (.idea/modules/kotlin-graphql-sample.iml, .idea/modules/kotlin-graphql-sample_main.iml, and .idea/modules/kotlin-graphql-sample_test.iml) are not.

Fix

IntelliJ Support page says:

You may consider not to share the following:

  • .iml files and .idea/modules.xml file for the Gradle or Maven based projects, since these files will be generated on import

This pull request makes .idea/modules.xml not version-controlled.

Additionally it rearranges .gitignore file.

shiraji commented 5 years ago

LGTM