search

ubio / css

ubio CSS Framework
https://ubio.github.io/css
0 stars 0 forks source link

Removes custom scrollbar styling #12

Closed 1602 closed 6 years ago

1602 commented 6 years ago

So that user preferences can define scrollbar appearance (e.g. show scrollbar only on hover).

inca commented 6 years ago

Great idea btw! (scrollbar on hover)

muzafarova commented 6 years ago

This is user OS setting (scrollbar on hover) which we were overriding by CSS.. I believe it's not possible to force scrollbar on hover by CSS (I might be wrong)

@inca I'm going to merge and publish this one (for the first time 🎉) is it patch or should be "minor"? Is UDF relying on "tiny scrollbars" from this project?

muzafarova commented 6 years ago

image

this is it ^

1602 commented 6 years ago

Strictly speaking this is a breaking change, since it requires all clients to add some css to handle scrollbars (so that everything stays the same). Not sure what are the rules about this in css world (everything looks like a breaking change there).

Looking at amount of changes, looks like a patch.

muzafarova commented 6 years ago

Given the early stage of the project and amount of current clients (Autopilot-UDF and test-runner), we agreed that this was just a patch :3

On Mon, Mar 19, 2018 at 5:39 PM, Anatoliy notifications@github.com wrote:

Strictly speaking this is a breaking change, since it requires all clients to add some css to handle scrollbars (so that everything stays the same). Not sure what are the rules about this in css world (everything looks like a breaking change there).

Looking at amount of changes, looks like a patch.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/universalbasket/css/pull/12#issuecomment-374301331, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFLDv8qJmrnu87UmEeBeil8PJwxZygUks5tf-1dgaJpZM4SvZmr .