search

ubiq / sparrow-extension-OLD

Sparrow browser extension for Ubiq (MetaMask's brother)
MIT License
7 stars 3 forks source link

Sparrow & Metamask does not work together in chromebrowser. locked and unlocked #6

Open oaapieg60 opened 6 years ago

oaapieg60 commented 6 years ago

I encountered a problem with the extensions. I have the Sparrow & Metamask extensions. I find out that they work against each other.

Problem with Myetherwallet.com:

Situation: When Sparrow and Metamask unlocked. Problem: When logging in the "send tokens" menu from myetherwallet i select the option Metamask to login When Im in my wallet my ubiq addres appears under account address instead of my ethereum address.

Situation: When Sparrow locked and Metamask unlocked. Problem: Im doing the same thing as above, then nothing happens. Looks like he can not find metamask extension,

The same thing happened also on other websites for example "cryptokittys"

Situation: Sparrow unlocked & Metamask unlocked Problem: Ubiq adres shows up

Situation: Sparrow unlocked & Metamask Locked Problem: Ubiq adress shows up

Situation: Sparrow locked & Metamask unlocked Problem: Website cant find my extension

Metamask working fine if i shut down Sparrow in the extension settings. Browser used: Google chrome browser Operating system: Windows 10 [ installed fullversion Azure, visual studio]

Here a few screenshots.

cryptokittysmetamask1 unlockcedunlocked sparrowunlockedmetalocked myetherwalletunlocked unlocked

aldoborrero commented 6 years ago

Thanks for filling this issue @oaapieg60!

Although we have been working to not collide MetaMask and Sparrow injecting Web3 (the library required to operate with Ethereum/Ubiq RPC nodes), the behavior you're experiencing is because there's no way now of differentiating if the dApp is built with Ubiq compatibility or not, so depending on the page and what plugin loads first, you will definitely experience those issues you shared before.

For now, the only solution I advise is to disable both extensions and enable one or another depending on the situation.

Am going to forward this to MetaMask guys to see if we can find a nice solution without resorting on hacks or disabling extensions.

DaneWiid1 commented 6 years ago

@aldoborrero any chance you can set web3.currentProvider to return "SparrowInpageProvider" instead of "MetamaskInpageProvider" . That way we can prompt users to switch off the plugin they aren't using in the meantime.

DaneWiid1 commented 6 years ago

@aldoborrero any feedback on this issue ?

aldoborrero commented 6 years ago

Hi @DaneWiid1 at the moment I'm very busy and I can't afford the time to make the change, do you mind if you can send a PR? I'll merge it!

Thanks for your understanding and sorry!